From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egG7G-0007MN-19 for qemu-devel@nongnu.org; Mon, 29 Jan 2018 15:33:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egG7F-0002pD-1n for qemu-devel@nongnu.org; Mon, 29 Jan 2018 15:33:22 -0500 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:46459) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egG7E-0002oe-R1 for qemu-devel@nongnu.org; Mon, 29 Jan 2018 15:33:20 -0500 Received: by mail-qt0-x244.google.com with SMTP id o35so14394828qtj.13 for ; Mon, 29 Jan 2018 12:33:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <75ba8c40-803f-4652-93d9-852c97334aad@linaro.org> References: <1514940265-18093-1-git-send-email-mjc@sifive.com> <1514940265-18093-7-git-send-email-mjc@sifive.com> <14dcf85d-a8e0-fc21-df46-b94fe48d1067@linaro.org> <75ba8c40-803f-4652-93d9-852c97334aad@linaro.org> From: Jim Wilson Date: Mon, 29 Jan 2018 12:33:19 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Michael Clark , qemu-devel@nongnu.org, Bastian Koppelmann , Sagar Karandikar , RISC-V Patches On Wed, Jan 24, 2018 at 3:47 PM, Richard Henderson wrote: > On 01/24/2018 10:58 AM, Jim Wilson wrote: >> Although, looking at this again, I see another statement in a >> different place that says: >> >> Except when otherwise stated, if the result of a floating-point operation is >> NaN, it is the canonical NaN. The canonical NaN has a positive sign and all >> significand bits clear except the MSB, a.k.a. the quiet bit. For >> single-precision floating-point, this corresponds to the pattern >> 0x7fc00000. > Yes, I had read this before as well. I had assumed that your patch constituted > an intended change to this text. > >> This could take a little time to sort out. > Ok. I don't see this as a blocking issue for merging. So after looking at this a bit more, I've come to the conclusion that my patch to remove the default/canonical nan support from RISC-V qemu was wrong. We will have to fix this on the gcc/glibc side. Michael, please revert my change https://github.com/riscv/riscv-qemu/commit/4223d89b0c5c671332d66bcd649db5c6f46559f5 Jim