From: Dmitry Fleytman <dmitry@daynix.com>
To: qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yan@daynix.com>,
Dmitry Fleytman <dmitry@daynix.com>,
Chris Webb <chris.webb@elastichosts.com>,
Richard Davies <richard.davies@elastichosts.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] A few race conditions in E1000 device fixed
Date: Mon, 15 Oct 2012 22:30:14 +0200 [thread overview]
Message-ID: <CAGHCxhedEyAHWncJcpDevFKy6izCFfZnQVXJPUtEx2UavYYoUg@mail.gmail.com> (raw)
In-Reply-To: <1350319733-7306-1-git-send-email-dmitry@daynix.com>
Hello,
Please, ignore 1st patch for now.
Although it fixes the problem observed it looks like there is a better
and easier solution (many thanks to Intel Guys that explained e1000
operation in details:
http://sourceforge.net/mailarchive/forum.php?thread_name=CAGHCxhcad%3Dzx7ihX5zoDB%3DZOLGGuZty%3DBck6zSoMQ-9S3ZJo7w%40mail.gmail.com&forum_name=e1000-devel).
We'll submit the final patch soon.
Dmitry.
On Mon, Oct 15, 2012 at 6:48 PM, Dmitry Fleytman <dmitry@daynix.com> wrote:
> Following patches fix a few race conditions in E1000 code:
>
> 1st patch fixes race condition between driver shutdown and device shutdown (see patch comment)
> It also work-arounds race condition in e1000 Linux driver between RX enable and RX rings init
> (Separate patch for the second problem sent to e1000-devel/linux/kernel and accepted by maintainers, see
> http://sourceforge.net/mailarchive/forum.php?thread_name=1350280341.2152.12.camel%40jtkirshe-mobl&forum_name=e1000-devel)
>
> 2nd patch is pretty trivial and adds forgotten field into live migration list thus fixing another race condition.
>
> Dmitry Fleytman (2):
> Fix a race condition in E1000 device implementation:
> Fix a race condition in E1000 device live migration. One of
> data-transfer related flags not in migrated fields list.
>
> hw/e1000.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> --
> 1.7.11.4
>
--
Dmitry Fleytman
Technology Expert and Consultant,
Daynix Computing Ltd.
Cell: +972-54-2819481
Skype: dmitry.fleytman
prev parent reply other threads:[~2012-10-15 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 16:48 [Qemu-devel] [PATCH 0/2] A few race conditions in E1000 device fixed Dmitry Fleytman
2012-10-15 16:48 ` [Qemu-devel] [PATCH 1/2] Fix a race condition in E1000 device implementation: Dmitry Fleytman
2012-10-15 16:48 ` [Qemu-devel] [PATCH 2/2] Fix a race condition in E1000 device live migration. One of data-transfer related flags not in migrated fields list Dmitry Fleytman
2012-10-16 8:32 ` Stefan Hajnoczi
2012-10-16 9:43 ` Kevin Wolf
2012-10-15 20:30 ` Dmitry Fleytman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHCxhedEyAHWncJcpDevFKy6izCFfZnQVXJPUtEx2UavYYoUg@mail.gmail.com \
--to=dmitry@daynix.com \
--cc=chris.webb@elastichosts.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.davies@elastichosts.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).