Re: [PATCH v4] chardev: add path option for pty backend

[Octavian Purdila <tavip@google.com>]

On Tue, Sep 3, 2024 at 12:14 AM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
>
>
> On Tue, Aug 6, 2024 at 5:09 AM Octavian Purdila <tavip@google.com> wrote:
>>
>> Add path option to the pty char backend which will create a symbolic
>> link to the given path that points to the allocated PTY.
>>
>> This avoids having to make QMP or HMP monitor queries to find out what
>> the new PTY device path is.
>>
>> Based on patch from Paulo Neves:
>>
>> https://patchew.org/QEMU/1548509635-15776-1-git-send-email-ptsneves@gmail.com/
>>
>> Tested with the following invocations that the link is created and
>> removed when qemu stops:
>>
>>   qemu-system-x86_64 -nodefaults -mon chardev=compat_monitor \
>>   -chardev pty,path=test,id=compat_monitor0
>>
>>   qemu-system-x86_64 -nodefaults -monitor pty:test
>>
>>   # check QMP invocation with path set
>>   qemu-system-x86_64 -nodefaults -qmp tcp:localhost:4444,server=on,wait=off
>>   nc localhost 4444
>>   > {"execute": "qmp_capabilities"}
>>   > {"execute": "chardev-add", "arguments": {"id": "bar", "backend": {
>>       "type": "pty", "data": {"path": "test" }}}}
>>
>>   # check QMP invocation with path not set
>>   qemu-system-x86_64 -nodefaults -qmp tcp:localhost:4444,server=on,wait=off
>>   nc localhost 4444
>>   > {"execute": "qmp_capabilities"}
>>   > {"execute": "chardev-add", "arguments": {"id": "bar", "backend": {
>>       "type": "pty", "data": {}}}}
>>
>> Also tested that when a link path is not passed invocations still work, e.g.:
>>
>>   qemu-system-x86_64 -monitor pty
>>
>> Co-authored-by: Paulo Neves <ptsneves@gmail.com>
>> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
>> [OP: rebase and address original patch review comments]
>> Signed-off-by: Octavian Purdila <tavip@google.com>
>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>

Ping, it looks like this got lost.

https://patchew.org/QEMU/20240605185050.1678102-1-tavip@google.com/