qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bharata B Rao <bharata.rao@gmail.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	Igor Mammedov <imammedo@redhat.com>,
	ChenFan <chen.fan.fnst@cn.fujitsu.com>,
	Anshul Makkar <anshul.makkar@profitbricks.com>,
	"afaerber@suse.de" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects
Date: Mon, 15 Sep 2014 15:39:59 +0530	[thread overview]
Message-ID: <CAGZKiBoGi4rD1wbDgGMsvt0g5ihRcKvRK_hDRL5ZbGGCoPwXQw@mail.gmail.com> (raw)
In-Reply-To: <541689AF.8010205@cn.fujitsu.com>

On Mon, Sep 15, 2014 at 12:09 PM, Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
> Hi Bharata,
> On 09/12/2014 09:52 PM, Bharata B Rao wrote:
>
>> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar
>> <anshul.makkar@profitbricks.com> wrote:
>>> During plugging we can see this event: echo 1 > cpu8/online.
>>>
>>> But during unplugging , we can't see the event echo 0 > cpu8/online.
>>
>> That's because I didn't do that explicitly, was always trying to
>> remove an online cpu from the monitor w/o explicitly offlining it from
>> inside the guest. Either ways I still see the removed CPU being listed
>> in QEMU monitor.
>>
>> I don't ever hit any of the below code paths during CPU removal:
>
> It seems that the guest OS did not call the "_EJ0" method.
> Could you please dump the guest os' acpi dsdt, and check whether the "_EJ0"
> method exists?

_EJ0 doesn't exist in my DSDT.

>
>>
>> cpus.c: qemu_kvm_destroy_vcpu()
>> cpus.c: x86_cpu_finalizefn()
>>
>> I see CPU_REMOVE() being called from above two routines.
>>
>> And neither does hw/acpi/cpu_hotplug.c:cpu_status_write() gets called
>> here. Does the message "ACPI: Device does not support D3cold" guest
>> kernel throws during hot removal is causing this behaviour here ?
>> Guest kernel is 3.11.10, should I be on latest kernel ?
>
> I have tested the fedora 20 guest with the default kernel, it works well,
> so the kernel should be fine.
> One more question, is the guest kernel config the same as fedora 20's default one?

Yes, I am running the distro provided kernel.

Regards,
Bharata.

  reply	other threads:[~2014-09-15 10:10 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  3:36 [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 01/10] cpu: introduce CpuTopoInfo structure for argument simplification Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 02/10] qom/cpu: move register_vmstate to common CPUClass.realizefn Gu Zheng
2014-09-09 12:17   ` Igor Mammedov
2014-09-10  2:38     ` Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 03/10] cpu: add device_add foo-x86_64-cpu support Gu Zheng
2014-09-09 12:44   ` Igor Mammedov
2014-09-10  3:37     ` Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 04/10] x86: add x86_cpu_unrealizefn() for cpu apic remove Gu Zheng
2014-09-09 13:58   ` Igor Mammedov
2014-09-11  3:06     ` Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 05/10] i386: add cpu device_del support Gu Zheng
2014-09-09 14:11   ` Igor Mammedov
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 06/10] qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier' Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 07/10] qom cpu: add UNPLUG cpu notify support Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 08/10] i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c Gu Zheng
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 09/10] cpu hotplug: implement function cpu_status_write() for vcpu ejection Gu Zheng
2014-09-09 14:28   ` Igor Mammedov
2014-08-28  3:36 ` [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects Gu Zheng
2014-09-09 14:40   ` Igor Mammedov
2014-09-10  3:54     ` Gu Zheng
2014-09-11  9:35   ` Bharata B Rao
2014-09-11  9:49     ` Gu Zheng
2014-09-11  9:53     ` Gu Zheng
2014-09-11 12:37       ` Bharata B Rao
2014-09-12  1:24         ` Gu Zheng
2014-09-12  8:09           ` Bharata B Rao
2014-09-12  9:53             ` Gu Zheng
2014-09-12 10:30               ` Bharata B Rao
2014-09-12 10:53               ` Anshul Makkar
2014-09-12 13:52                 ` Bharata B Rao
2014-09-12 15:34                   ` Anshul Makkar
2014-09-15  6:39                   ` Gu Zheng
2014-09-15 10:09                     ` Bharata B Rao [this message]
2014-09-15 10:33                       ` Anshul Makkar
2014-09-15 13:53                         ` Bharata B Rao
2014-09-15 14:29                           ` Anshul Makkar
2014-09-11 10:03     ` Anshul Makkar
2014-09-12 14:15   ` Igor Mammedov
2014-09-15  5:03     ` Gu Zheng
2014-12-08  9:16   ` Bharata B Rao
2014-12-08  9:26     ` Peter Maydell
2014-12-08 10:28       ` Gu Zheng
2014-12-08 10:50         ` Peter Maydell
2014-12-08 15:38           ` Igor Mammedov
2014-12-08 16:38             ` Peter Maydell
2014-12-09  0:58               ` Gu Zheng
2014-12-08 10:12     ` Gu Zheng
2014-11-12  1:46 ` [Qemu-devel] [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support Gu Zheng
2014-11-12  1:46 ` Gu Zheng
2014-11-12  7:57   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZKiBoGi4rD1wbDgGMsvt0g5ihRcKvRK_hDRL5ZbGGCoPwXQw@mail.gmail.com \
    --to=bharata.rao@gmail.com \
    --cc=afaerber@suse.de \
    --cc=anshul.makkar@profitbricks.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).