From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTTEP-0007ny-MP for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTTEO-0004Lo-7D for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:10:01 -0400 Received: from mail-vc0-x235.google.com ([2607:f8b0:400c:c03::235]:58153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTTEO-0004Lk-2E for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:10:00 -0400 Received: by mail-vc0-f181.google.com with SMTP id ij19so3096064vcb.26 for ; Mon, 15 Sep 2014 03:09:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <541689AF.8010205@cn.fujitsu.com> References: <1409197002-9498-1-git-send-email-guz.fnst@cn.fujitsu.com> <1409197002-9498-11-git-send-email-guz.fnst@cn.fujitsu.com> <54117105.8000007@cn.fujitsu.com> <54124B47.2050504@cn.fujitsu.com> <5412C2B6.4020603@cn.fujitsu.com> <541689AF.8010205@cn.fujitsu.com> Date: Mon, 15 Sep 2014 15:39:59 +0530 Message-ID: From: Bharata B Rao Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: "qemu-devel@nongnu.org" , tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Igor Mammedov , ChenFan , Anshul Makkar , "afaerber@suse.de" On Mon, Sep 15, 2014 at 12:09 PM, Gu Zheng wrote: > Hi Bharata, > On 09/12/2014 09:52 PM, Bharata B Rao wrote: > >> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar >> wrote: >>> During plugging we can see this event: echo 1 > cpu8/online. >>> >>> But during unplugging , we can't see the event echo 0 > cpu8/online. >> >> That's because I didn't do that explicitly, was always trying to >> remove an online cpu from the monitor w/o explicitly offlining it from >> inside the guest. Either ways I still see the removed CPU being listed >> in QEMU monitor. >> >> I don't ever hit any of the below code paths during CPU removal: > > It seems that the guest OS did not call the "_EJ0" method. > Could you please dump the guest os' acpi dsdt, and check whether the "_EJ0" > method exists? _EJ0 doesn't exist in my DSDT. > >> >> cpus.c: qemu_kvm_destroy_vcpu() >> cpus.c: x86_cpu_finalizefn() >> >> I see CPU_REMOVE() being called from above two routines. >> >> And neither does hw/acpi/cpu_hotplug.c:cpu_status_write() gets called >> here. Does the message "ACPI: Device does not support D3cold" guest >> kernel throws during hot removal is causing this behaviour here ? >> Guest kernel is 3.11.10, should I be on latest kernel ? > > I have tested the fedora 20 guest with the default kernel, it works well, > so the kernel should be fine. > One more question, is the guest kernel config the same as fedora 20's default one? Yes, I am running the distro provided kernel. Regards, Bharata.