From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata.rao@gmail.com>) id 1ZppNL-0006dM-6q
	for qemu-devel@nongnu.org; Fri, 23 Oct 2015 23:20:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata.rao@gmail.com>) id 1ZppNK-0000oW-9k
	for qemu-devel@nongnu.org; Fri, 23 Oct 2015 23:20:11 -0400
Received: from mail-wi0-x244.google.com ([2a00:1450:400c:c05::244]:34462)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata.rao@gmail.com>) id 1ZppNK-0000oM-2v
	for qemu-devel@nongnu.org; Fri, 23 Oct 2015 23:20:10 -0400
Received: by wicuk10 with SMTP id uk10so8605750wic.1
	for <qemu-devel@nongnu.org>; Fri, 23 Oct 2015 20:20:09 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1445216059-88521-18-git-send-email-guangrong.xiao@linux.intel.com>
References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1445216059-88521-18-git-send-email-guangrong.xiao@linux.intel.com>
Date: Sat, 24 Oct 2015 08:50:08 +0530
Message-ID: <CAGZKiBqR7scJ73CPSv0B1_hYyZ4Tet-qcyHayJ9powyT9L-fNw@mail.gmail.com>
From: Bharata B Rao <bharata.rao@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 17/33] dimm: abstract dimm device from
	pc-dimm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org, "mst@redhat.com" <mst@redhat.com>, gleb@kernel.org, mtosatti@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, dan.j.williams@intel.com, Richard Henderson <rth@twiddle.net>

On Mon, Oct 19, 2015 at 6:24 AM, Xiao Guangrong
<guangrong.xiao@linux.intel.com> wrote:
> A base device, dimm, is abstracted from pc-dimm, so that we can
> build nvdimm device based on dimm in the later patch
>
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> ---
>  default-configs/i386-softmmu.mak   |  1 +
>  default-configs/x86_64-softmmu.mak |  1 +
>  hw/mem/Makefile.objs               |  3 ++-
>  hw/mem/dimm.c                      | 11 ++-------
>  hw/mem/pc-dimm.c                   | 46 ++++++++++++++++++++++++++++++++++++++
>  include/hw/mem/dimm.h              |  4 ++--
>  include/hw/mem/pc-dimm.h           |  7 ++++++
>  7 files changed, 61 insertions(+), 12 deletions(-)
>  create mode 100644 hw/mem/pc-dimm.c
>  create mode 100644 include/hw/mem/pc-dimm.h
>
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index 43c96d1..3ece8bb 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -18,6 +18,7 @@ CONFIG_FDC=y
>  CONFIG_ACPI=y
>  CONFIG_ACPI_X86=y
>  CONFIG_ACPI_X86_ICH=y
> +CONFIG_DIMM=y
>  CONFIG_ACPI_MEMORY_HOTPLUG=y
>  CONFIG_ACPI_CPU_HOTPLUG=y
>  CONFIG_APM=y
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> index dfb8095..92ea7c1 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -18,6 +18,7 @@ CONFIG_FDC=y
>  CONFIG_ACPI=y
>  CONFIG_ACPI_X86=y
>  CONFIG_ACPI_X86_ICH=y
> +CONFIG_DIMM=y

Same change needs to be done in default-configs/ppc64-softmmu.mak too.

Regards,
Bharata.