From: Bharata B Rao <bharata.rao@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] X86 CPU topology broken in qemu ?
Date: Tue, 30 Aug 2011 11:13:48 +0530 [thread overview]
Message-ID: <CAGZKiBqo=o56qxWJCibSAKoJDXHKNLV49CVmdtpwXyXLNTwmXQ@mail.gmail.com> (raw)
In-Reply-To: <4E56284B.6020002@siemens.com>
On Thu, Aug 25, 2011 at 4:17 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2011-08-17 07:25, Bharata B Rao wrote:
>> Index: qemu-kvm-0.14.1/target-i386/kvm.c
>> ===================================================================
>> --- qemu-kvm-0.14.1.orig/target-i386/kvm.c
>> +++ qemu-kvm-0.14.1/target-i386/kvm.c
>> @@ -340,6 +340,9 @@ int kvm_arch_init_vcpu(CPUState *env)
>>
>> cpuid_i = 0;
>>
>> + if (env->cpuid_features & CPUID_APIC)
>> + env->cpuid_apic_id = env->cpu_index;
>> +
>
> Moving it only here will break TCG mode. Make sure to test both. I guess
> it's best to move cpuid_apic_id initialization into cpu_x86_init. And
> you need to take care of the external APIC case (i486) as well.
Thanks for the review. The patch was just a quick fix. Let me work on
a proper fix that addresses your comments.
Regards,
Bharata.
prev parent reply other threads:[~2011-08-30 5:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGZKiBpbqMALiRdNRqd0WN6iqNWpnkOcsvVb8AzJAGocuWBrTw@mail.gmail.com>
2011-08-17 5:25 ` [Qemu-devel] X86 CPU topology broken in qemu ? Bharata B Rao
2011-08-19 9:51 ` Bharata B Rao
2011-08-25 10:01 ` Avi Kivity
2011-08-30 5:42 ` Bharata B Rao
2011-08-25 10:47 ` Jan Kiszka
2011-08-30 5:43 ` Bharata B Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZKiBqo=o56qxWJCibSAKoJDXHKNLV49CVmdtpwXyXLNTwmXQ@mail.gmail.com' \
--to=bharata.rao@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).