From: Hao Wu <wuhaotsh@google.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
IS20 Avi Fishman <Avi.Fishman@nuvoton.com>,
CS20 KFTing <kfting@nuvoton.com>,
Havard Skinnemoen <hskinnemoen@google.com>,
Patrick Venture <venture@google.com>, Doug Evans <dje@google.com>,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH v2 0/6] hw/i2c: Add NPCM7XX SMBus Device
Date: Wed, 10 Feb 2021 13:26:30 -0800 [thread overview]
Message-ID: <CAGcCb101mQGaGw3h2e8t=+uYfb8fw+gUezSi55nnr1-8886=eg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-nx02EKVZLRxDYyY6uY4jyZ5ag3uk_Cak8zZqTuF32tg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
Thanks. I'll take patch 1 out of the next version.
On Mon, Feb 8, 2021 at 9:01 AM Peter Maydell <peter.maydell@linaro.org>
wrote:
> On Fri, 29 Jan 2021 at 01:04, Hao Wu <wuhaotsh@google.com> wrote:
> >
> > This patch set implements the System manager bus (SMBus) module in
> NPCM7XX
> > SoC. Basically, it emulates the data transactions of the module, not the
> > SDA/SCL levels. We have also added a QTest which contains read and write
> > operations for both single-byte and FIFO mode, and added basic I2C
> devices
> > for npcm750-evb and quanta-gsj boards.
> >
> > We also cleaned up the unimplemented GPIO devices in npcm7xx.c since they
> > are already implemented.
> >
> > Changes since v1:
> > - Fix errors for i2c device addresses for temperature sensors in GSJ
> machine
> > - Use at24c device to emulate GSJ EEPROM. It supports more than 256
> bytes.
> > - Fill in VMState in npcm7xx_smbus.c
> > - Change commit message in patch 3 and 4
> > - Fix order in npcm7xx.c IRQ list
> > - Add a few extra comments to make things clearer
> >
> > Hao Wu (6):
> > hw/arm: Remove GPIO from unimplemented NPCM7XX
> > hw/i2c: Implement NPCM7XX SMBus Module Single Mode
> > hw/arm: Add I2C sensors for NPCM750 eval board
> > hw/arm: Add I2C sensors and EEPROM for GSJ machine
> > hw/i2c: Add a QTest for NPCM7XX SMBus Device
> > hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode
>
> Hi; I'm going to apply patch 1 to target-arm.next because it's not
> really related to the others in the series. For the rest, I left
> a couple of review comments but they're pretty minor.
>
> thanks
> -- PMM
>
[-- Attachment #2: Type: text/html, Size: 2145 bytes --]
prev parent reply other threads:[~2021-02-10 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 0:58 [PATCH v2 0/6] hw/i2c: Add NPCM7XX SMBus Device wuhaotsh--- via
2021-01-29 0:58 ` [PATCH v2 1/6] hw/arm: Remove GPIO from unimplemented NPCM7XX wuhaotsh--- via
2021-02-08 16:48 ` Peter Maydell
2021-01-29 0:58 ` [PATCH v2 2/6] hw/i2c: Implement NPCM7XX SMBus Module Single Mode wuhaotsh--- via
2021-01-29 0:58 ` [PATCH v2 3/6] hw/arm: Add I2C sensors for NPCM750 eval board wuhaotsh--- via
2021-02-08 16:48 ` Peter Maydell
2021-01-29 0:58 ` [PATCH v2 4/6] hw/arm: Add I2C sensors and EEPROM for GSJ machine wuhaotsh--- via
2021-02-08 16:51 ` Peter Maydell
2021-01-29 0:58 ` [PATCH v2 5/6] hw/i2c: Add a QTest for NPCM7XX SMBus Device wuhaotsh--- via
2021-02-08 16:51 ` Peter Maydell
2021-01-29 0:58 ` [PATCH v2 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode wuhaotsh--- via
2021-02-08 16:59 ` Peter Maydell
2021-02-10 21:42 ` Hao Wu
2021-02-08 17:01 ` [PATCH v2 0/6] hw/i2c: Add NPCM7XX SMBus Device Peter Maydell
2021-02-10 21:26 ` Hao Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGcCb101mQGaGw3h2e8t=+uYfb8fw+gUezSi55nnr1-8886=eg@mail.gmail.com' \
--to=wuhaotsh@google.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=cminyard@mvista.com \
--cc=dje@google.com \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).