From: Hao Wu via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Corey Minyard" <minyard@acm.org>,
"Patrick Venture" <venture@google.com>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"CS20 KFTing" <kfting@nuvoton.com>,
qemu-arm <qemu-arm@nongnu.org>,
"IS20 Avi Fishman" <Avi.Fishman@nuvoton.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v4 0/6] Additional NPCM7xx devices
Date: Tue, 5 Jan 2021 13:56:22 -0800 [thread overview]
Message-ID: <CAGcCb10FdAJs2qkwU3COtapt-xtNAAJg7oVPCFdE-LUHFjwBKQ@mail.gmail.com> (raw)
In-Reply-To: <20201217004349.3740927-1-wuhaotsh@google.com>
[-- Attachment #1: Type: text/plain, Size: 2870 bytes --]
Ping?
On Wed, Dec 16, 2020 at 4:45 PM Hao Wu <wuhaotsh@google.com> wrote:
> This patch series include a few more NPCM7XX devices including
>
> - Analog Digital Converter (ADC)
> - Pulse Width Modulation (PWM)
>
> We also modified the CLK module to generate clock values using qdev_clock.
> These clocks are used to determine various clocks in NPCM7XX devices.
>
> Thank you for your review.
>
> Changes since v3:
> - Use type casting instead of accessing parent object in all devices.
>
> Changes since v2:
> - Split PWM test into a separate patch in the patch set
> - Add trace events for PWM's update_freq/update_duty
> - Add trace events for ioread/iowrite in ADC and PWM
> - Use timer_get_ns in hw/timer/npcm7xx_timer.c
> - Update commit message in ADC/PWM to mention qom-get/set method for usage
> - Fix typos
>
> Changes since v1:
> - We removed the IPMI and KCS related code from this patch set.
>
> Hao Wu (6):
> hw/misc: Add clock converter in NPCM7XX CLK module
> hw/timer: Refactor NPCM7XX Timer to use CLK clock
> hw/adc: Add an ADC module for NPCM7XX
> hw/misc: Add a PWM module for NPCM7XX
> hw/misc: Add QTest for NPCM7XX PWM Module
> hw/*: Use type casting for SysBusDevice in NPCM7XX
>
> docs/system/arm/nuvoton.rst | 4 +-
> hw/adc/meson.build | 1 +
> hw/adc/npcm7xx_adc.c | 321 +++++++++++++
> hw/adc/trace-events | 5 +
> hw/arm/npcm7xx.c | 55 ++-
> hw/arm/npcm7xx_boards.c | 2 +-
> hw/mem/npcm7xx_mc.c | 2 +-
> hw/misc/meson.build | 1 +
> hw/misc/npcm7xx_clk.c | 797 ++++++++++++++++++++++++++++++-
> hw/misc/npcm7xx_gcr.c | 2 +-
> hw/misc/npcm7xx_pwm.c | 559 ++++++++++++++++++++++
> hw/misc/npcm7xx_rng.c | 2 +-
> hw/misc/trace-events | 6 +
> hw/nvram/npcm7xx_otp.c | 2 +-
> hw/ssi/npcm7xx_fiu.c | 2 +-
> hw/timer/npcm7xx_timer.c | 25 +-
> include/hw/adc/npcm7xx_adc.h | 72 +++
> include/hw/arm/npcm7xx.h | 4 +
> include/hw/misc/npcm7xx_clk.h | 146 +++++-
> include/hw/misc/npcm7xx_pwm.h | 106 ++++
> include/hw/timer/npcm7xx_timer.h | 1 +
> meson.build | 1 +
> tests/qtest/meson.build | 4 +-
> tests/qtest/npcm7xx_adc-test.c | 400 ++++++++++++++++
> tests/qtest/npcm7xx_pwm-test.c | 490 +++++++++++++++++++
> 25 files changed, 2972 insertions(+), 38 deletions(-)
> create mode 100644 hw/adc/npcm7xx_adc.c
> create mode 100644 hw/adc/trace-events
> create mode 100644 hw/misc/npcm7xx_pwm.c
> create mode 100644 include/hw/adc/npcm7xx_adc.h
> create mode 100644 include/hw/misc/npcm7xx_pwm.h
> create mode 100644 tests/qtest/npcm7xx_adc-test.c
> create mode 100644 tests/qtest/npcm7xx_pwm-test.c
>
> --
> 2.29.2.684.gfbc64c5ab5-goog
>
>
[-- Attachment #2: Type: text/html, Size: 3575 bytes --]
prev parent reply other threads:[~2021-01-05 21:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 0:43 [PATCH v4 0/6] Additional NPCM7xx devices Hao Wu via
2020-12-17 0:43 ` [PATCH v4 1/6] hw/misc: Add clock converter in NPCM7XX CLK module Hao Wu via
2021-01-07 20:39 ` Peter Maydell
2020-12-17 0:43 ` [PATCH v4 2/6] hw/timer: Refactor NPCM7XX Timer to use CLK clock Hao Wu via
2021-01-07 20:51 ` Peter Maydell
2021-01-07 21:43 ` Hao Wu via
2020-12-17 0:43 ` [PATCH v4 3/6] hw/adc: Add an ADC module for NPCM7XX Hao Wu via
2021-01-07 21:07 ` Peter Maydell
2021-01-07 21:58 ` Hao Wu via
2020-12-17 0:43 ` [PATCH v4 4/6] hw/misc: Add a PWM " Hao Wu via
2020-12-17 0:43 ` [PATCH v4 5/6] hw/misc: Add QTest for NPCM7XX PWM Module Hao Wu via
2021-01-07 21:10 ` Peter Maydell
2020-12-17 0:43 ` [PATCH v4 6/6] hw/*: Use type casting for SysBusDevice in NPCM7XX Hao Wu via
2021-01-07 21:08 ` Peter Maydell
2021-01-05 21:56 ` Hao Wu via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGcCb10FdAJs2qkwU3COtapt-xtNAAJg7oVPCFdE-LUHFjwBKQ@mail.gmail.com \
--to=qemu-devel@nongnu.org \
--cc=Avi.Fishman@nuvoton.com \
--cc=f4bug@amsat.org \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=minyard@acm.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).