From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B149C433E0 for ; Tue, 5 Jan 2021 21:57:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C37E522D71 for ; Tue, 5 Jan 2021 21:57:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C37E522D71 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwuKb-0003Ba-I5 for qemu-devel@archiver.kernel.org; Tue, 05 Jan 2021 16:57:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwuJn-0002d2-1c for qemu-devel@nongnu.org; Tue, 05 Jan 2021 16:56:43 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:39511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwuJl-0004za-0i for qemu-devel@nongnu.org; Tue, 05 Jan 2021 16:56:42 -0500 Received: by mail-lf1-x134.google.com with SMTP id a12so2021493lfl.6 for ; Tue, 05 Jan 2021 13:56:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CJTR5P+O1pAD9ZwARwSZ/K8/6oUZwdn6dUQpE4KreUU=; b=X3nJsZLrGDkre0IxhwB9gU76MRmgh7NQQkgtmp+2qgfMN2myC1CqKbyupf/g2JGSKB ePT96owqK6R0bUltPu1FuQg5iF09pnelWWk46QC8eHo1iOdCnVN11L6zkHbmabV+v/vu o5uQ9VJs/ggBrzXEHevTQMOLE8m8l6/Z2UVqtsWHeN6Xl0WoczwVZn+MKfKNEO2aCCaN AEdihsmfHRofpW/EEzwAxde7+/D9BhED9pdFBZpgbdQZbPbDsHSh/v/LHum5/Mcs2YpY dA7kpcBmfs7Oa9yvL5p4Yz5UEUP9AfWXPt39D4KbcBeOtQV4Zj5zMKY2DhtvZ83v/BEX qcEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CJTR5P+O1pAD9ZwARwSZ/K8/6oUZwdn6dUQpE4KreUU=; b=ZAbKiKB8WNsrInsaUnPEGIlakaXGODbofY+vqwvr4vRuvRnEPt+LvSEf/0zhWTfY3x D87xmojvUt8b6CSgsHki681FQ6EoRzldS4OjV/MHGvJR+nM0LgpOTU+i/TVPzhGTOcWY rCF47RRTzbjTNp8IMV46PRX6y0Rq1i7xdbUHIoThykQGQtICV0Slves40gps2hrj4dje d92K6AaA+ZLZMe6lpJITT2rI/Dg2EAsGLPUsDfoWyzAicaQahCh9s+MEBVeqADsWgQ+5 eDCR/xMwzWACKZwqKl9QLluyo8e6oGIZNFkxUNY6oSqCEsoOk+XIejgHvVTdnOu4oAbr 7RQw== X-Gm-Message-State: AOAM531HRJkbYHdlzwB4R9OVAd5t2GcLP1rzRDTTsZBEQ6z1ndmMNdnj zaJtd2zG0pw0muM3XGET6XXm1g2XUxGWYJQT9gqGtQ== X-Google-Smtp-Source: ABdhPJxffchFhmbHgephTF5b7gfCY6BL6aQlHOAEktndKsAUg0Hy3o5GayMBhJkuWUGHuaDX9gKLuRni5Kd2+We6SRY= X-Received: by 2002:ac2:4d14:: with SMTP id r20mr576847lfi.410.1609883793668; Tue, 05 Jan 2021 13:56:33 -0800 (PST) MIME-Version: 1.0 References: <20201217004349.3740927-1-wuhaotsh@google.com> In-Reply-To: <20201217004349.3740927-1-wuhaotsh@google.com> Date: Tue, 5 Jan 2021 13:56:22 -0800 Message-ID: Subject: Re: [PATCH v4 0/6] Additional NPCM7xx devices To: Peter Maydell Content-Type: multipart/alternative; boundary="000000000000a7214905b82e4742" Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=wuhaotsh@google.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -179 X-Spam_score: -18.0 X-Spam_bar: ------------------ X-Spam_report: (-18.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.369, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Patrick Venture , Havard Skinnemoen , QEMU Developers , CS20 KFTing , qemu-arm , IS20 Avi Fishman , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Hao Wu From: Hao Wu via --000000000000a7214905b82e4742 Content-Type: text/plain; charset="UTF-8" Ping? On Wed, Dec 16, 2020 at 4:45 PM Hao Wu wrote: > This patch series include a few more NPCM7XX devices including > > - Analog Digital Converter (ADC) > - Pulse Width Modulation (PWM) > > We also modified the CLK module to generate clock values using qdev_clock. > These clocks are used to determine various clocks in NPCM7XX devices. > > Thank you for your review. > > Changes since v3: > - Use type casting instead of accessing parent object in all devices. > > Changes since v2: > - Split PWM test into a separate patch in the patch set > - Add trace events for PWM's update_freq/update_duty > - Add trace events for ioread/iowrite in ADC and PWM > - Use timer_get_ns in hw/timer/npcm7xx_timer.c > - Update commit message in ADC/PWM to mention qom-get/set method for usage > - Fix typos > > Changes since v1: > - We removed the IPMI and KCS related code from this patch set. > > Hao Wu (6): > hw/misc: Add clock converter in NPCM7XX CLK module > hw/timer: Refactor NPCM7XX Timer to use CLK clock > hw/adc: Add an ADC module for NPCM7XX > hw/misc: Add a PWM module for NPCM7XX > hw/misc: Add QTest for NPCM7XX PWM Module > hw/*: Use type casting for SysBusDevice in NPCM7XX > > docs/system/arm/nuvoton.rst | 4 +- > hw/adc/meson.build | 1 + > hw/adc/npcm7xx_adc.c | 321 +++++++++++++ > hw/adc/trace-events | 5 + > hw/arm/npcm7xx.c | 55 ++- > hw/arm/npcm7xx_boards.c | 2 +- > hw/mem/npcm7xx_mc.c | 2 +- > hw/misc/meson.build | 1 + > hw/misc/npcm7xx_clk.c | 797 ++++++++++++++++++++++++++++++- > hw/misc/npcm7xx_gcr.c | 2 +- > hw/misc/npcm7xx_pwm.c | 559 ++++++++++++++++++++++ > hw/misc/npcm7xx_rng.c | 2 +- > hw/misc/trace-events | 6 + > hw/nvram/npcm7xx_otp.c | 2 +- > hw/ssi/npcm7xx_fiu.c | 2 +- > hw/timer/npcm7xx_timer.c | 25 +- > include/hw/adc/npcm7xx_adc.h | 72 +++ > include/hw/arm/npcm7xx.h | 4 + > include/hw/misc/npcm7xx_clk.h | 146 +++++- > include/hw/misc/npcm7xx_pwm.h | 106 ++++ > include/hw/timer/npcm7xx_timer.h | 1 + > meson.build | 1 + > tests/qtest/meson.build | 4 +- > tests/qtest/npcm7xx_adc-test.c | 400 ++++++++++++++++ > tests/qtest/npcm7xx_pwm-test.c | 490 +++++++++++++++++++ > 25 files changed, 2972 insertions(+), 38 deletions(-) > create mode 100644 hw/adc/npcm7xx_adc.c > create mode 100644 hw/adc/trace-events > create mode 100644 hw/misc/npcm7xx_pwm.c > create mode 100644 include/hw/adc/npcm7xx_adc.h > create mode 100644 include/hw/misc/npcm7xx_pwm.h > create mode 100644 tests/qtest/npcm7xx_adc-test.c > create mode 100644 tests/qtest/npcm7xx_pwm-test.c > > -- > 2.29.2.684.gfbc64c5ab5-goog > > --000000000000a7214905b82e4742 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ping?

On Wed, Dec 16, 2020 at 4:45 PM Hao Wu <wuhaotsh@google.com> wrote:
This patch series include a= few more NPCM7XX devices including

- Analog Digital Converter (ADC)
- Pulse Width Modulation (PWM)

We also modified the CLK module to generate clock values using qdev_clock.<= br> These clocks are used to determine various clocks in NPCM7XX devices.

Thank you for your review.

Changes since v3:
- Use type casting instead of accessing parent object in all devices.

Changes since v2:
- Split PWM test into a separate patch in the patch set
- Add trace events for PWM's update_freq/update_duty
- Add trace events for ioread/iowrite in ADC and PWM
- Use timer_get_ns in hw/timer/npcm7xx_timer.c
- Update commit message in ADC/PWM to mention qom-get/set method for usage<= br> - Fix typos

Changes since v1:
- We removed the IPMI and KCS related code from this patch set.

Hao Wu (6):
=C2=A0 hw/misc: Add clock converter in NPCM7XX CLK module
=C2=A0 hw/timer: Refactor NPCM7XX Timer to use CLK clock
=C2=A0 hw/adc: Add an ADC module for NPCM7XX
=C2=A0 hw/misc: Add a PWM module for NPCM7XX
=C2=A0 hw/misc: Add QTest for NPCM7XX PWM Module
=C2=A0 hw/*: Use type casting for SysBusDevice in NPCM7XX

=C2=A0docs/system/arm/nuvoton.rst=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A04 +- =C2=A0hw/adc/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 =C2=A01 +
=C2=A0hw/adc/npcm7xx_adc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= 321 +++++++++++++
=C2=A0hw/adc/trace-events=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A05 +
=C2=A0hw/arm/npcm7xx.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0|=C2=A0 55 ++-
=C2=A0hw/arm/npcm7xx_boards.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A02 +-
=C2=A0hw/mem/npcm7xx_mc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A02 +-
=C2=A0hw/misc/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A01 +
=C2=A0hw/misc/npcm7xx_clk.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 797 = ++++++++++++++++++++++++++++++-
=C2=A0hw/misc/npcm7xx_gcr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 =C2=A02 +-
=C2=A0hw/misc/npcm7xx_pwm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 559 = ++++++++++++++++++++++
=C2=A0hw/misc/npcm7xx_rng.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 =C2=A02 +-
=C2=A0hw/misc/trace-events=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 =C2=A06 +
=C2=A0hw/nvram/npcm7xx_otp.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A02 +-
=C2=A0hw/ssi/npcm7xx_fiu.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 =C2=A02 +-
=C2=A0hw/timer/npcm7xx_timer.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 25 = +-
=C2=A0include/hw/adc/npcm7xx_adc.h=C2=A0 =C2=A0 =C2=A0|=C2=A0 72 +++
=C2=A0include/hw/arm/npcm7xx.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2= =A04 +
=C2=A0include/hw/misc/npcm7xx_clk.h=C2=A0 =C2=A0 | 146 +++++-
=C2=A0include/hw/misc/npcm7xx_pwm.h=C2=A0 =C2=A0 | 106 ++++
=C2=A0include/hw/timer/npcm7xx_timer.h |=C2=A0 =C2=A01 +
=C2=A0meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
=C2=A0tests/qtest/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A04 +-
=C2=A0tests/qtest/npcm7xx_adc-test.c=C2=A0 =C2=A0| 400 ++++++++++++++++
=C2=A0tests/qtest/npcm7xx_pwm-test.c=C2=A0 =C2=A0| 490 +++++++++++++++++++<= br> =C2=A025 files changed, 2972 insertions(+), 38 deletions(-)
=C2=A0create mode 100644 hw/adc/npcm7xx_adc.c
=C2=A0create mode 100644 hw/adc/trace-events
=C2=A0create mode 100644 hw/misc/npcm7xx_pwm.c
=C2=A0create mode 100644 include/hw/adc/npcm7xx_adc.h
=C2=A0create mode 100644 include/hw/misc/npcm7xx_pwm.h
=C2=A0create mode 100644 tests/qtest/npcm7xx_adc-test.c
=C2=A0create mode 100644 tests/qtest/npcm7xx_pwm-test.c

--
2.29.2.684.gfbc64c5ab5-goog

--000000000000a7214905b82e4742--