From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38D91C433EF for ; Tue, 8 Mar 2022 18:54:17 +0000 (UTC) Received: from localhost ([::1]:45606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nReyO-000831-6H for qemu-devel@archiver.kernel.org; Tue, 08 Mar 2022 13:54:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRexR-0006rH-O0 for qemu-devel@nongnu.org; Tue, 08 Mar 2022 13:53:17 -0500 Received: from [2607:f8b0:4864:20::f30] (port=33499 helo=mail-qv1-xf30.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRexQ-0000LA-6o for qemu-devel@nongnu.org; Tue, 08 Mar 2022 13:53:17 -0500 Received: by mail-qv1-xf30.google.com with SMTP id jq9so210257qvb.0 for ; Tue, 08 Mar 2022 10:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=phJ0KRh+qoV1VJHIW3W94dQ7PhLGPjLfVmNNIu3Cxyw=; b=X1ZhfdEusdA/Jy/RCobfJfhMXKtaRlBvCOYE8r1NCRNmEIOEXNxvFrOYlpkRt7l2sj 9TDnwn6z62xqqASfwaBoUUYfYauQKncAmFF4owMTmfYUNzizKcc869+MTI2UFKOefXje AA4pbV6k1a7alBbadAYU4uokSkxHPJEgFUh3ddgN9pXMFZQFuUVdHSNQwleUDvexDQWL rZABXI16fE+RCClJk+X0fbGYEtp7I6/k09xmRyYM92pfQFNwMeGxB1StmBJLgIWTr/dC LaqVrdQv14Bsc6Kv6/0Dvs9X6vET2xv9XoRmNbBb4RskRoK9jz5Uozw51YIx0p9T5/59 ZxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=phJ0KRh+qoV1VJHIW3W94dQ7PhLGPjLfVmNNIu3Cxyw=; b=hDsf6T1i86jk1uTvDJEoVOdRDTf/TxQf9d/TUkJMD3LPOO9cYpRh7L4UHlp5U36S13 vE0Vuk2dNU8oQn7SFPGPVZZt2jNd5oQ2Gfea6X+vHVHkyegt6HlRkVropjit0/7bedmN luPNiKhfGP10aRltLMpdzK+sZKulC/bJjNdSRDorOQ5sQYNXHqgwnbR+QVNSaG5A6zdd KDWZUiUHgaxiFUrg5fbmZht2RFc4qos54lH4F4xNbg7zk3468Ju7IZJOEjL64WryP5tl KXPgp2F0hndJN/V7TQocIVcHvUUqgtaE2FqrYRCDT8BOWc+28D5AycHnKAduIm7gLJWZ ncag== X-Gm-Message-State: AOAM5326oxvEhzom5WPAN9I+fWAkihbvUgvJy3Lm8468c9GWnAKyC4+i kELFUAR6cPHQu91fwIpk0l5q00mXrBo0dHwey1TUNg== X-Google-Smtp-Source: ABdhPJxXk3gMHSO9bMHft09/Mi+E8myinRrXdAVVWi2YoGxw9YxDBeRBLywFK5ujJ7SSVH4+mKpMUBIkYBl4spZGYS0= X-Received: by 2002:ad4:5ba5:0:b0:435:ac65:b179 with SMTP id 5-20020ad45ba5000000b00435ac65b179mr3346006qvq.97.1646765593211; Tue, 08 Mar 2022 10:53:13 -0800 (PST) MIME-Version: 1.0 References: <20220308170302.2582820-1-peter.maydell@linaro.org> <1293fd43-c952-8c23-a903-485a15ec6366@linaro.org> In-Reply-To: <1293fd43-c952-8c23-a903-485a15ec6366@linaro.org> From: Hao Wu Date: Tue, 8 Mar 2022 10:53:02 -0800 Message-ID: Subject: Re: [PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init() To: Richard Henderson Cc: Peter Maydell , qemu-arm , QEMU Developers , Tyrone Ting , Havard Skinnemoen Content-Type: multipart/alternative; boundary="00000000000036d10105d9b97ec2" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f30 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=wuhaotsh@google.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -161 X-Spam_score: -16.2 X-Spam_bar: ---------------- X-Spam_report: (-16.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000036d10105d9b97ec2 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 8, 2022 at 10:09 AM Richard Henderson < richard.henderson@linaro.org> wrote: > On 3/8/22 07:03, Peter Maydell wrote: > > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > > Use g_autofree so we free it rather than leaking it. > > > > (Detected with the clang leak sanitizer.) > > > > Signed-off-by: Peter Maydell > > --- > > hw/misc/npcm7xx_clk.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Richard Henderson > > Reviewed-by: Hao Wu > r~ > > --00000000000036d10105d9b97ec2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Mar 8, 2022 at 10:09 AM Richa= rd Henderson <richard.he= nderson@linaro.org> wrote:
On 3/8/22 07:03, Peter Maydell wrote:
> In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf().=
> Use g_autofree so we free it rather than leaking it.
>
> (Detected with the clang leak sanitizer.)
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>=C2=A0 =C2=A0hw/misc/npcm7xx_clk.c | 4 ++--
>=C2=A0 =C2=A01 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Hao Wu <wuhaotsh@google.com>=C2=A0
r~

--00000000000036d10105d9b97ec2--