* Re: [PATCH] hw/arm: enable at24c with aspeed
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
@ 2024-10-28 18:19 ` Hao Wu
2024-10-29 0:43 ` Andrew Jeffery
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hao Wu @ 2024-10-28 18:19 UTC (permalink / raw)
To: Patrick Leis
Cc: clg, peter.maydell, steven_lee, leetroy, jamin_lin, andrew, joel,
qemu-arm, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Mon, Oct 28, 2024 at 11:15 AM Patrick Leis <venture@google.com> wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
>
> Signed-off-by: Patrick Leis <venture@google.com>
>
Reviewed-by: Hao Wu <wuhaotsh@google.com>
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index e7fd9338d1..1b25e73578 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -539,6 +539,7 @@ config ASPEED_SOC
> select PMBUS
> select MAX31785
> select FSI_APB2OPB_ASPEED
> + select AT24C
>
> config MPS2
> bool
> --
> 2.47.0.163.g1226f6d8fa-goog
>
>
>
[-- Attachment #2: Type: text/html, Size: 1310 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw/arm: enable at24c with aspeed
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
2024-10-28 18:19 ` Hao Wu
@ 2024-10-29 0:43 ` Andrew Jeffery
2024-10-29 4:58 ` Philippe Mathieu-Daudé
2024-11-02 14:58 ` Cédric Le Goater
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2024-10-29 0:43 UTC (permalink / raw)
To: Patrick Leis, clg, peter.maydell, steven_lee, Troy Lee, jamin_lin,
joel
Cc: qemu-arm, qemu-devel
On Mon, 2024-10-28 at 18:14 +0000, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
>
> Signed-off-by: Patrick Leis <venture@google.com>
I was wondering how we haven't hit problems before now. Poking around
with scripts/minikconf.py for an arm-softmmu build we get:
# config AT24C depends on I2C
# select AT24C if NPCM7XX
# => AT24C is now True
# config AT24C default y if E500
# config AT24C default n
Seems reasonable that the Aspeed models should select it themselves
given they depend on the symbols.
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/arm: enable at24c with aspeed
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
2024-10-28 18:19 ` Hao Wu
2024-10-29 0:43 ` Andrew Jeffery
@ 2024-10-29 4:58 ` Philippe Mathieu-Daudé
2024-11-02 14:58 ` Cédric Le Goater
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-29 4:58 UTC (permalink / raw)
To: Patrick Leis, clg, peter.maydell, steven_lee, leetroy, jamin_lin,
andrew, joel
Cc: qemu-arm, qemu-devel
On 28/10/24 15:14, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
Maybe explicit the at24c_eeprom_init_rom() call which instanciate
TYPE_AT24C_EE.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Signed-off-by: Patrick Leis <venture@google.com>
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/arm: enable at24c with aspeed
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
` (2 preceding siblings ...)
2024-10-29 4:58 ` Philippe Mathieu-Daudé
@ 2024-11-02 14:58 ` Cédric Le Goater
3 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2024-11-02 14:58 UTC (permalink / raw)
To: Patrick Leis, peter.maydell, steven_lee,
leetroy@gmail.com >> Troy Lee, jamin_lin, andrew, joel
Cc: qemu-arm, qemu-devel
On 10/28/24 19:14, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
>
> Signed-off-by: Patrick Leis <venture@google.com>
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index e7fd9338d1..1b25e73578 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -539,6 +539,7 @@ config ASPEED_SOC
> select PMBUS
> select MAX31785
> select FSI_APB2OPB_ASPEED
> + select AT24C
>
> config MPS2
> bool
Applied to aspeed-next.
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread