From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rs6xq-00061M-2x for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:13:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rs6xm-0001nb-5u for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:13:10 -0500 Received: from mail-yw0-f43.google.com ([209.85.213.43]:39002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rs6xm-0001nT-0c for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:13:06 -0500 Received: by yhkk6 with SMTP id k6so52708yhk.30 for ; Mon, 30 Jan 2012 22:13:05 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20120131055547.GA23981@richard> References: <20120131055547.GA23981@richard> From: Mulyadi Santosa Date: Tue, 31 Jan 2012 13:12:24 +0700 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Yang Cc: qemu-devel@nongnu.org Hi :) On Tue, Jan 31, 2012 at 12:55, Richard Yang wrote: > > Hi, experts > > I am just coming to the qemu world. > > While reading the code, I am wondering why put a struct definition in the > c file? > > Seems there is no error in compile, while I felt it is not a proper way > to do it. maybe someone just forgot to refactor it :) I suggest to send a patch to do just that and let's see what everybody thinks about. I, myself thinks that the more readable the code is, the better -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogspot.com training: mulyaditraining.blogspot.com