From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1UydNY-0003Ab-Ib
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:39:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1UydNX-0001ZY-7s
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:39:28 -0400
Received: from mail-pb0-x22d.google.com ([2607:f8b0:400e:c01::22d]:49643)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donald.open@gmail.com>) id 1UydNX-0001ZN-1A
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 03:39:27 -0400
Received: by mail-pb0-f45.google.com with SMTP id mc8so10948877pbc.4
	for <qemu-devel@nongnu.org>; Mon, 15 Jul 2013 00:39:25 -0700 (PDT)
MIME-Version: 1.0
Sender: donald.open@gmail.com
In-Reply-To: <51DDBAAD.3070808@redhat.com>
References: <1371547919-15654-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<20130704125243.GE4213@stefanha-thinkpad.redhat.com>
	<51DC758A.8020200@redhat.com> <51DDBAAD.3070808@redhat.com>
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Date: Mon, 15 Jul 2013 15:38:45 +0800
Message-ID: <CAGrFBsip72y-crPntyJ+LEoHi+aO=mp8LW-im7SUtumcd_VNWw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with
 QemuOpts parser
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Thu, Jul 11, 2013 at 3:49 AM, Eric Blake <eblake@redhat.com> wrote:
> On 07/09/2013 02:41 PM, Eric Blake wrote:
>> On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote:
>>> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote:
>>>> These patches will replace QEMUOptionParameter with QemuOpts. Change logs
>>>> please go to each patch's commit message.
>>>>
>>>> Dong Xu Wang (7):
>>>>   add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print
>>>>   avoid duplication of default value in QemuOpts
>>>>   Create four QemuOptsList related functions
>>>>   Create some QemuOpts functons
>>>>   Use QemuOpts support in block layer
>>>>   query-command-line-options outputs def_value_str
>>>>   remove QEMUOptionParameter related functions and struct
>>>>
>>
>>>> V15->V16:
>>>> 1) discard double-initialization.
>>>> 2) use pointer directly, not g_strdup.
>>>> 3) modify query-command-line-options related code.
>>>> V14->V15:
>>>> 1) Only delete enum QEMUOptionParType.
>>>
>>> eblake: You commented on the last revision.  Are you happy with v16?
>>
>> Apologies for my delays (still digging myself out of 3 weeks
>> accumulation of mail after my vacation); I'll review within 24 hours.
>
> At this point, I think a v17 is warranted (comments on individual patches).
>
Thanks all of your comments, I will send v17 this week.
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>