From: Atish Kumar Patra <atishp@rivosinc.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Anup Patel <anup@brainfault.org>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <alistair.francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR ops.
Date: Fri, 28 Jan 2022 16:52:32 -0800 [thread overview]
Message-ID: <CAHBxVyGsHd=XqSN42Bem6_jwxw7BJDCLhurc4HvtNK+zeZyKcA@mail.gmail.com> (raw)
In-Reply-To: <936ade43-0fc9-56a5-f7a3-17180128a985@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Sun, Jan 23, 2022 at 11:56 PM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 1/21/22 7:07 AM, Atish Patra wrote:
> > + [CSR_VSTART] = { "vstart", vs, read_vstart, write_vstart,
> NULL,
> > + NULL, NULL,
> PRIV_VERSION_1_12_0 },
>
> I think adding all of these NULLs are hard to read.
> Better to just add
>
> .min_priv_ver = PRIV_VERSION_1_12_0
>
> to the existing entry.
>
>
Yeah. That's better. Fixed it.
>
> r~
>
[-- Attachment #2: Type: text/html, Size: 1071 bytes --]
next prev parent reply other threads:[~2022-01-29 1:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 20:07 [RFC 0/5] Privilege version update Atish Patra
2022-01-20 20:07 ` [RFC 1/5] target/riscv: Add the privileged spec version 1.12.0 Atish Patra
2022-01-24 7:59 ` Richard Henderson
2022-01-29 0:52 ` Atish Kumar Patra
2022-01-31 6:33 ` Alistair Francis
2022-01-20 20:07 ` [RFC 2/5] target/riscv: Introduce privilege version field in the CSR ops Atish Patra
2022-01-24 7:56 ` Richard Henderson
2022-01-29 0:52 ` Atish Kumar Patra [this message]
2022-01-20 20:07 ` [RFC 3/5] target/riscv: Add support for mconfigptr Atish Patra
2022-01-20 20:07 ` [RFC 4/5] target/riscv: Add *envcfg* CSRs support Atish Patra
2022-01-26 8:37 ` Weiwei Li
2022-01-29 1:28 ` Atish Patra
2022-01-29 1:50 ` angell1518
2022-01-31 20:05 ` Atish Kumar Patra
2022-02-03 12:23 ` Heiko Stübner
2022-02-03 20:39 ` Atish Kumar Patra
2022-01-20 20:07 ` [RFC 5/5] target/riscv: Enable privileged spec version 1.12 Atish Patra
2022-01-24 13:32 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHBxVyGsHd=XqSN42Bem6_jwxw7BJDCLhurc4HvtNK+zeZyKcA@mail.gmail.com' \
--to=atishp@rivosinc.com \
--cc=alistair.francis@wdc.com \
--cc=anup@brainfault.org \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).