From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52CDEC433EF for ; Sat, 29 Jan 2022 01:02:43 +0000 (UTC) Received: from localhost ([::1]:52502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDc8W-0005UL-Tr for qemu-devel@archiver.kernel.org; Fri, 28 Jan 2022 20:02:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDbyw-0002Gp-3F for qemu-devel@nongnu.org; Fri, 28 Jan 2022 19:52:46 -0500 Received: from [2a00:1450:4864:20::536] (port=33634 helo=mail-ed1-x536.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDbyu-0003vQ-9l for qemu-devel@nongnu.org; Fri, 28 Jan 2022 19:52:45 -0500 Received: by mail-ed1-x536.google.com with SMTP id b13so13365669edn.0 for ; Fri, 28 Jan 2022 16:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jacKjelwuptgZAZiU6SqOEH1L6PuokFoaXD3wLX6DXc=; b=xred+5df2gInUB+P0nc4kefYtMbluDh3xT67BuZkRVcTv4EeissUK3LEXGDvRYKNrw Ep2BFBZe2wBAfjcdz2QpGjQavZsUVGUpM7sTARkjB93jYuJFq7fhSlpC0b01kfttqsUa 1ztjQMasl2qAUowJEpV+sWgyqB3UVa6r1TRQxhRJCfD1ffx5l5qlQVloWd4iYTRL+u8j 6OK7wXWYqvaHCkuKerHddBoeE+kd7EnDeCc2dil/OTQU3vfgRNEP+jwI4tDLSk7xhG4/ /lI2ivVzUP0PcXbqGGZS/1UOHG5wgnnEzJNOBZNJSKrE9UR60/hWcEanrI4ioNbMTwhG QA5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jacKjelwuptgZAZiU6SqOEH1L6PuokFoaXD3wLX6DXc=; b=yUd58Kj/hh0Td5uFMZnlwZEXiCH3vZCNn9qG7qxhSkuvVj6XSzJRrNjdERIKq1kd0M ZfV4rPTJFns0v+N+4k2ipvoJnctMcqyNU9t8S7Y3dvtvXeMUzEPBvkpkB6Jff2gB3Fam QSkZFFfIlb/iKDLEiHGC2uVPbbY8GKOZg82nwHu4DJQvKrBQvvUiSPH9Vx5OtTmbzdEc QDfmG2cjEi3fyROLXh6sArF1nlLUbtikjU59yxKQCs5fEgUFvAGKtIEP3miloAohWDyu iAqL7PVYcXOkuFY/7wJuhoyy4xharsZkhNlGjDT1LIqmp+kXY8chN6A+P+GRpno267Kb gttw== X-Gm-Message-State: AOAM53345WR9F3SUeIaEnnhn3oRnk+YMGJkZkFFK7fwCCHLRAEt6YWQ3 PHqjgv7XBcMhVFuoZr4pdtxClTNe1IHOVdOx5jrx3A== X-Google-Smtp-Source: ABdhPJy6rE7wU6gxBMyf5hB14ITEO09l6rzMMjcAEY8rwEYQAwnJBT6Ug9qP0M0h/I/kuxOT3MiNbT9rsJMBIRt85Ls= X-Received: by 2002:a05:6402:5107:: with SMTP id m7mr10647363edd.408.1643417563105; Fri, 28 Jan 2022 16:52:43 -0800 (PST) MIME-Version: 1.0 References: <20220120200735.2739543-1-atishp@rivosinc.com> <20220120200735.2739543-3-atishp@rivosinc.com> <936ade43-0fc9-56a5-f7a3-17180128a985@linaro.org> In-Reply-To: <936ade43-0fc9-56a5-f7a3-17180128a985@linaro.org> From: Atish Kumar Patra Date: Fri, 28 Jan 2022 16:52:32 -0800 Message-ID: Subject: Re: [RFC 2/5] target/riscv: Introduce privilege version field in the CSR ops. To: Richard Henderson Content-Type: multipart/alternative; boundary="000000000000111c0a05d6adf897" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::536 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=atishp@rivosinc.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Anup Patel , Bin Meng , "qemu-devel@nongnu.org Developers" , Alistair Francis , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000111c0a05d6adf897 Content-Type: text/plain; charset="UTF-8" On Sun, Jan 23, 2022 at 11:56 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 1/21/22 7:07 AM, Atish Patra wrote: > > + [CSR_VSTART] = { "vstart", vs, read_vstart, write_vstart, > NULL, > > + NULL, NULL, > PRIV_VERSION_1_12_0 }, > > I think adding all of these NULLs are hard to read. > Better to just add > > .min_priv_ver = PRIV_VERSION_1_12_0 > > to the existing entry. > > Yeah. That's better. Fixed it. > > r~ > --000000000000111c0a05d6adf897 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 23, 2022 at 11:56 PM Rich= ard Henderson <richard.h= enderson@linaro.org> wrote:
On 1/21/22 7:07 AM, Atish Patra wrote:
> +=C2=A0 =C2=A0 [CSR_VSTART]=C2=A0 =C2=A0=3D { "vstart",=C2= =A0 =C2=A0vs,=C2=A0 =C2=A0 =C2=A0read_vstart,=C2=A0 write_vstart, NULL,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0NULL, NULL, PRIV_VERSION_1_12_0 },

I think adding all of these NULLs are hard to read.
Better to just add

=C2=A0 =C2=A0 =C2=A0.min_priv_ver =3D PRIV_VERSION_1_12_0

to the existing entry.


Yeah. That's better. Fixed it.
=C2=A0

r~
--000000000000111c0a05d6adf897--