From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ettvg-0002tc-FI for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:41:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ettve-00050S-U4 for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:41:48 -0500 Received: from mail-ot0-x231.google.com ([2607:f8b0:4003:c0f::231]:38439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ettve-0004xu-N1 for qemu-devel@nongnu.org; Thu, 08 Mar 2018 06:41:46 -0500 Received: by mail-ot0-x231.google.com with SMTP id 95so5110671ote.5 for ; Thu, 08 Mar 2018 03:41:44 -0800 (PST) MIME-Version: 1.0 References: <1520365586-30384-1-git-send-email-mjc@sifive.com> In-Reply-To: From: Michael Clark Date: Thu, 08 Mar 2018 11:41:33 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Bastian Koppelmann , Palmer Dabbelt , QEMU Developers , RISC-V Patches , Sagar Karandikar On Fri, 9 Mar 2018 at 12:18 AM, Michael Clark wrote: > On Fri, 9 Mar 2018 at 12:10 AM, Michael Clark wrote: > >> On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell >> wrote: >> >>> On 6 March 2018 at 19:46, Michael Clark wrote: >>> > -----BEGIN PGP SIGNED MESSAGE----- >>> > Hash: SHA1 >>> > >>> > The following changes since commit >>> f32408f3b472a088467474ab152be3b6285b2d7b: >>> > >>> > misc: don't use hwaddr as a type in trace events (2018-03-06 >>> 14:24:30 +0000) >>> > >>> > are available in the git repository at: >>> > >>> > https://github.com/riscv/riscv-qemu.git >>> tags/riscv-qemu-upstream-v8.2 >>> > >>> > for you to fetch changes up to >>> 7051b081bf6796e5e84406f6223a7c4900bf7298: >>> > >>> > RISC-V - Remove support for adhoc non-standard X_COP local-interrup= t >>> (2018-03-07 08:36:03 +1300) >>> >>> >>> Hi -- I would have applied this, but some of the commits >>> have no signed-off-by lines. >>> >>> This is important, and I've already asked for it once. We cannot >>> accept anything that doesn't have a clear record in the commit >>> message of everybody (person or company) who's contributed code >>> to it, indicating that they're happy for their copyrighted >>> contributions to be taken into QEMU under our license. Lists >>> of names without emails in the cover letter are not sufficient. >>> >>> In fact a lot of the last part of this patchset looks like >>> unreviewed changes/fixes that if we were going to have them we >>> should have squashed into the correct patches and resent the >>> series for review. Please don't do this. Code review is an >>> important part of how the QEMU project works. >> >> >> You must be looking at the wrong tag. There are multiple sign-offs in al= l >> 23 commits. The tag is riscv-qemu-upstream-v8.2. Sagar and Bastian >> contacted me out of band to add their sign-offs. Please look at the comm= its >> again and tell me which commit id doesn=E2=80=99t have a sign-off on tha= t tag (23 >> commits iirc) >> > > I can forward you the mail out-of-band. I had to contact contributors to > get them to agree to change the license from MIT to GPLv2, based on a > request from Red Hat. > > You are making this very hard. Do you work for Arm perchance? I really > wouldn=E2=80=99t be surprised if our port is being sandbagged by Arm. Apo= logies for > being so direct about this, but things like this happen... > > I have complied with practically every review request and the sign-offs > are there. It=E2=80=99s a bit ridiculous. > > It would be nice to find someone neutral, unrelated to Arm, to merge our = PR > Some history on the origins of RISC to put things in perspective: https://en.m.wikipedia.org/wiki/Berkeley_RISC David Patterson worked with Andrew Waterman and Krste Asanovic on the design of RISC-V. Sagar did most of the work on the QEMU port and he agreeded to sign off on all patches. The SiFive patches only have sign-offs from SiFive because SiFive was the sole contributor for its hardware model, beside the SiFiveUART which has Stefan=E2=80=99s sign-off. In any case it seems there is not enough review bandwidth in the QEMU project as a whole and the policy to accept contributions is too strict to be reasonable, given earnest attempts to comply with *all* review feedback. Not impressed. >