qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Raymond <cerbere@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets
Date: Wed, 27 Jul 2011 09:55:02 -0400	[thread overview]
Message-ID: <CAHWZs7VbfrECzwb08-vjRJLcoGXo-OnmPJg0C436qa5FHzFeKA@mail.gmail.com> (raw)
In-Reply-To: <m3k4b4z2nh.fsf@blackfin.pond.sub.org>

> There are many more object files that are built conditionally.  Why is
> it okay not to delete them?

Perhaps they should be deleted too...

The GNU Make manual says the following about "distclean":
http://www.gnu.org/s/hello/manual/make/Standard-Targets.html

"Delete all files in the current directory (or created by this
makefile) that are created by configuring or building the program. If
you have unpacked the source and built the program without creating
any other files, ‘make distclean’ should leave only the files that
were in the distribution. However, there is no need to delete parent
directories that were created with ‘mkdir -p’, since they could have
existed anyway. "

Now, if everyone agrees that "distclean" is fine as it is, I won't
insist on anything.


>
> If you unwisely messed up your source tree by building in it, a simple
> and reliable way out is to git-clone yourself a new one.  Or if you
> insist on recovering in-place, remove files outside .git that aren't in
> git.
>

Indeed.

Alexandre

  reply	other threads:[~2011-07-27 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  3:56 [Qemu-devel] [PATCH 0/2] Minor makefile fixes Alexandre Raymond
2011-07-26  3:56 ` [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets Alexandre Raymond
2011-07-26  6:47   ` Markus Armbruster
2011-07-26 13:51     ` Alexandre Raymond
2011-07-27  5:57       ` Markus Armbruster
2011-07-27 13:55         ` Alexandre Raymond [this message]
2011-07-27 14:42           ` [Qemu-devel] [Qemu-trivial] " Michael Roth
2011-07-29 11:20             ` Paolo Bonzini
2011-07-26  3:56 ` [Qemu-devel] [PATCH 2/2] Makefile: delete config.log in distclean Alexandre Raymond
2011-07-29 11:07   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHWZs7VbfrECzwb08-vjRJLcoGXo-OnmPJg0C436qa5FHzFeKA@mail.gmail.com \
    --to=cerbere@gmail.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).