Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

[Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>]

On Wed, Jul 1, 2020 at 1:05 PM chen huacai <zltjiangshi@gmail.com> wrote:
>
> Hi, Philippe and Alexandar,
>
> On Wed, Jul 1, 2020 at 4:49 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >
> > On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote:
> > > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote:
> > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote:
> > >>> Paul Burton and Aurelien Jarno removed for not being present.
> > >>>
> > >>> Huacai Chen and Jiaxun Yang step in as new energy.
> > >>>
> > >>> CC: Paul Burton <paulburton@kernel.org>
> > >>> CC: Aurelien Jarno <aurelien@aurel32.net>
> > >>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> ---
> > >>>  MAINTAINERS | 15 ++++++++++-----
> > >>>  1 file changed, 10 insertions(+), 5 deletions(-)
> > >>>
> > >>> diff --git a/MAINTAINERS b/MAINTAINERS
> > >>> index 5d8acf8d31..7fc16e21c9 100644
> > >>> --- a/MAINTAINERS
> > >>> +++ b/MAINTAINERS
> > >>> @@ -213,7 +213,8 @@ F: disas/microblaze.c
> > >>>
> > >>>  MIPS TCG CPUs
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> -R: Aurelien Jarno <aurelien@aurel32.net>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >>>  S: Maintained
> > >>>  F: target/mips/
> > >>> @@ -377,6 +378,7 @@ F: target/arm/kvm.c
> > >>>
> > >>>  MIPS KVM CPUs
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >>>  S: Odd Fixes
> > >>>  F: target/mips/kvm.c
> > >>>
> > >>> @@ -1052,6 +1054,7 @@ MIPS Machines
> > >>>  -------------
> > >>>  Jazz
> > >>>  M: Hervé Poussineau <hpoussin@reactos.org>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >
> > > Hmm this is the Jazz hobbyist machine, Huacai are you sure this
> > > the correct section you want to be?
> > >
> > > Anyway Hervé Poussineau has to ack that, Aleksandar, it would
> > > be easier if you split this as a separate patch.
> > >
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >>>  S: Maintained
> > >>>  F: hw/mips/jazz.c
> > >>> @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c
> > >>>
> > >>>  Malta
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >>>  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > >>> -R: Aurelien Jarno <aurelien@aurel32.net>
> > >
> > > Last time Aurelien commented on the Malta machine, was on March 23,
> > > 3 months ago, then there hasn't been Malta patches. As a reviewer
> > > he is present and provides valuable feedback, why are you kicking
> > > him out? See:
> > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691406.html
> > >
> > > Huacai, has Jiangsu Lemote Tech Co., Ltd real interest to paid
> > > employees to maintain the Malta board?
> I think I can review TCG part and maintain KVM part currently, but
> can't maintain Jazz/Malta/Mipssim/R4k/Boston (maybe possible in
> future, but not now).
>

Sure, Huacai, I will respect your wish.

I truly like your cautious approach. Although, honestly speaking, your
credentials for being a maintainer are - at least - three order of
magnitude higher than for some other maintainer. But, people, here we
have a responsible, serious man - Huacai Chen! Bravo for caution,
bravo for being modest, and bravo for being not greedy!

My deep admiration! We want and we need such people in QEMU for MIPS!
There is a place for you here!

Aleksandar

> Thanks,
> Huacai
> > >
> > >>>  S: Maintained
> > >>>  F: hw/isa/piix4.c
> > >>>  F: hw/acpi/piix4.c
> > >>> @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py
> > >>>
> > >>>  Mipssim
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >>>  S: Odd Fixes
> > >
> > > Now that you have 2 maintainers, you can raise the status to Maintained.
> > >
> > >>>  F: hw/mips/mipssim.c
> > >>> @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c
> > >>>
> > >>>  R4000
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> -R: Aurelien Jarno <aurelien@aurel32.net>
> > >
> > > I'm sure Aurelien will agree with this part. But let's wait
> > > for his feedback.
> > >
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >>>  S: Obsolete
> > >>>  F: hw/mips/r4k.c
> > >>> @@ -1103,7 +1106,8 @@ S: Maintained
> > >>>  F: hw/intc/loongson_liointc.c
> > >>>
> > >>>  Boston
> > >>> -M: Paul Burton <pburton@wavecomp.com>
> > >>> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>
> > >> Missing in the patch description that you are taking this
> > >> machine over.
> > >
> > > After some rest I remember Paul said he'd come back on QEMU,
> > > so it doesn't look right to kick him out that way.
> > >
> > > Also in this thread you said you never saw a Boston board:
> > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691778.html
> > >
> > > Paul might welcome you as a co-maintainer, but I rather keep
> > > him for his expertise.
> >
> > Looking in archives, on Oct 20 2019 Paul said "it would be a pain
> > to me if the boston machine bitrotted or anything" and he planned
> > to find time to improve "the CM & MT ASE emulation".
> >
> > This was before Feb 19 2020 when he announced "[his] time with MIPS
> > the company has reached its end": https://lkml.org/lkml/2020/2/19/984
> >
> > Still this change requires an Ack from him.
> >
> > >
> > >>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >
> > > Huacai, similarly does Jiangsu Lemote Tech Co., Ltd have real
> > > interest in time to provide developers to maintain the Boston
> > > machine?
> > >
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >>>  S: Maintained
> > >>>  F: hw/core/loader-fit.c
> > >>> @@ -2677,7 +2681,8 @@ F: disas/i386.c
> > >>>
> > >>>  MIPS TCG target
> > >>>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > >>> -R: Aurelien Jarno <aurelien@aurel32.net>
> > >>> +M: Huacai Chen <chenhc@lemote.com>
> > >
> > > $ git log --author='Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l
> > > 0
> > >
> > > $ git log --grep='Reviewed-by: Huacai Chen <chenhc@lemote.com>'
> > > tcg/mips/ | wc -l
> > > 0
> > >
> > > git log --grep='Acked-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l
> > > 0
> > >
> > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > >
> > > $ git log --grep='Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>'
> > > tcg/mips/ | wc -l
> > > 0
> > >
> > > $ git log --grep='Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>'
> > > tcg/mips/ | wc -l
> > > 0
> > >
> > > I think you are confusing sections, Since Huacai and Jiaxun never showed
> > > interest in the TCG target code, how can they become maintainers?
> > >
> > >>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > >
> > > $ git log --grep='Reviewed-by: Aleksandar Rikalo' tcg/mips/ | wc -l
> > > 0
> > > $ git log --grep='Acked-by: Aleksandar Rikalo' tcg/mips/ | wc -l
> > > 0
> > >
> > > Apparently Aleksandar Rikalo can be "removed for not being present."
> > >
> > > OTOH FWIW:
> > > $ git log --author='Philippe Mathieu-Daudé' tcg/mips/ | wc -l
> > > 25
> > > $ git log --grep='Reviewed-by: Philippe Mathieu-Daudé' tcg/mips/ | wc -l
> > > 99
> > >
> > > So for this section changes:
> > > NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > >
> > > The rest is conditional of Paul Burton and Aurelien Jarno Ack-by.
> > >
> > >>>  S: Maintained
> > >>>  F: tcg/mips/
> > >>>
> > >>
> > >>
> > >
> >
>
>
> --
> Huacai Chen