Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>]

сре, 8. апр 2020. у 11:08 Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> Loongson processor prefers 16KB page size in system emulator, so let's
> define mc->minimum_page_bits to 14.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Huacai, thanks for the efforts regarding this series! I will very
likely accept patches 1/3 and 2/3 from this series in my next MIPS
queue, but the possible problem is that I somehow can't find patch 3/3
from my series in my mailbox. (I think it also the case with the cover
letter.) Could you perhaps resend the whole series? I'm concerned that
patch 3/3 contains something important, and it would be a shame that
it is omitted, and 1/3 and 2/3 are accepted.

For this patch:

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

>  hw/mips/mips_fulong2e.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index 5040afd..23897d7 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
>      mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
>      mc->default_ram_size = 256 * MiB;
>      mc->default_ram_id = "fulong2e.ram";
> +    mc->minimum_page_bits = 14;
>  }
>
>  DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
> --
> 2.7.0
>