From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
Gerd Hoffmann <kraxel@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning
Date: Sun, 3 May 2020 21:04:03 +0200 [thread overview]
Message-ID: <CAHiYmc6LC7B=Ce9a746emqqGbYCxtacFGd=TRBCzJiktRNWcXg@mail.gmail.com> (raw)
In-Reply-To: <20200503113220.30808-3-f4bug@amsat.org>
> +#if TARGET_ABI_BITS < TARGET_LONG_BITS
> /* Check if address fits target address space */
> if ((unsigned long)host_addr + new_size > (abi_ulong)-1) {
It would be clearer if "#if TARGET_LONG_BITS > TARGET_ABI_BITS"
is used, to match the comparison in if() statement.
> /* Revert mremap() changes */
> @@ -721,6 +722,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
> errno = ENOMEM;
> host_addr = MAP_FAILED;
> }
> +#endif /* TARGET_ABI_BITS < TARGET_LONG_BITS */
> }
>
> if (host_addr == MAP_FAILED) {
> --
> 2.21.3
>
>
next prev parent reply other threads:[~2020-05-03 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 11:32 [RFC PATCH 0/2] misc: fix Clang10 warnings Philippe Mathieu-Daudé
2020-05-03 11:32 ` [RFC PATCH 1/2] audio/mixeng: Fix Clang 'int-conversion' warning Philippe Mathieu-Daudé
2020-05-03 12:52 ` BALATON Zoltan
2020-05-03 17:12 ` Richard Henderson
2020-05-04 5:49 ` Volker Rümelin
2020-05-04 6:50 ` Philippe Mathieu-Daudé
2020-05-03 11:32 ` [RFC PATCH 2/2] linux-user/mmap: Fix Clang 'type-limit-compare' warning Philippe Mathieu-Daudé
2020-05-03 12:49 ` Aleksandar Markovic
2020-05-03 12:55 ` Aleksandar Markovic
2020-05-03 17:18 ` Richard Henderson
2020-05-03 19:04 ` Aleksandar Markovic [this message]
2020-06-03 16:06 ` Eric Blake
2020-06-03 18:01 ` Richard Henderson
2020-06-03 18:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHiYmc6LC7B=Ce9a746emqqGbYCxtacFGd=TRBCzJiktRNWcXg@mail.gmail.com' \
--to=aleksandar.qemu.devel@gmail.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).