From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Markus Armbruster" <armbru@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments
Date: Fri, 15 May 2020 13:19:55 +0200 [thread overview]
Message-ID: <CAHiYmc6mpd2bRS9FuA0xmARNPC_9W0rZeixkDqKAdx_fiB_QNw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9J6-qoyqJyH9mxhfX6oNhq+DkeFmGbsPbVgi0jX+qMMw@mail.gmail.com>
пет, 15. мај 2020. у 13:12 Peter Maydell <peter.maydell@linaro.org> је
написао/ла:
>
> On Fri, 15 May 2020 at 12:07, Aleksandar Markovic
> <aleksandar.qemu.devel@gmail.com> wrote:
> > I understood your points. They make sense to me. In hindsight, in
> > general, we shouldn't try just to silence checkpatch warnings (or, for
> > that matter, compiler warnings as well), but try to resolve the root
> > cause, the underlying issue, of the warning. In this case, creating
> > tracepoints seems to be the right thing to do.
>
> For this sort of "default case, guest accessed a bad register offset"
> case, what I usually do is something like
> qemu_log_mask(LOG_GUEST_ERROR, "malta_fpga_write: Bad register offset 0x"
> TARGET_FMT_lx "\n", addr);
>
> That's a simpler change than adding tracepoints and matches how
> we report this kind of guest-did-the-wrong-thing behaviour elsewhere.
>
Oh, great! I appreciate your remark and guidance very much!
I am going to correct this patch in v3.
Sincerely,
Aleksandar
> thanks
> -- PMM
prev parent reply other threads:[~2020-05-15 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 19:20 [PATCH v2 00/17] target/mips: FPU and other cleanups and improvements Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 01/17] target/mips: fpu: Demacro ADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 02/17] target/mips: fpu: Demacro SUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 03/17] target/mips: fpu: Demacro MUL.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 04/17] target/mips: fpu: Demacro DIV.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 05/17] target/mips: fpu: Remove now unused macro FLOAT_BINOP Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 06/17] target/mips: fpu: Demacro MADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 07/17] target/mips: fpu: Demacro MSUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 08/17] target/mips: fpu: Demacro NMADD.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 09/17] target/mips: fpu: Demacro NMSUB.<D|S|PS> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 10/17] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 11/17] target/mips: fpu: Demacro CLASS.<D|S> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 12/17] target/mips: fpu: Remove now unused FLOAT_CLASS macro Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 13/17] target/mips: fpu: Demacro RINT.<D|S> Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 14/17] target/mips: fpu: Remove now unused FLOAT_RINT macro Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 15/17] target/mips: fpu: Name better paired-single variables Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 16/17] target/mips: fpu: Refactor conversion from ieee to mips exception flags Aleksandar Markovic
2020-05-14 19:20 ` [PATCH v2 17/17] hw/mips: Convert Malta "ifdef 0"-ed code to comments Aleksandar Markovic
2020-05-15 7:53 ` Markus Armbruster
2020-05-15 11:05 ` Aleksandar Markovic
2020-05-15 11:12 ` Peter Maydell
2020-05-15 11:19 ` Aleksandar Markovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHiYmc6mpd2bRS9FuA0xmARNPC_9W0rZeixkDqKAdx_fiB_QNw@mail.gmail.com \
--to=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).