From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A720EC2BA15 for ; Sun, 5 Apr 2020 16:42:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E6ED20675 for ; Sun, 5 Apr 2020 16:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8jqEUqL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E6ED20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL8M3-0004bB-HH for qemu-devel@archiver.kernel.org; Sun, 05 Apr 2020 12:42:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46343) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL8LP-0004Bu-W4 for qemu-devel@nongnu.org; Sun, 05 Apr 2020 12:42:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL8LO-0001M3-In for qemu-devel@nongnu.org; Sun, 05 Apr 2020 12:41:59 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:51454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL8LO-0001LN-Bf for qemu-devel@nongnu.org; Sun, 05 Apr 2020 12:41:58 -0400 Received: by mail-wm1-x343.google.com with SMTP id z7so12205595wmk.1 for ; Sun, 05 Apr 2020 09:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8rRX4NUebl6MdSW2ICda+smEMgKSJytKBhnJgOF+Chg=; b=b8jqEUqL0zYpfIVbr+yjy/8lUxqE5NQWvc3Z/pc2w8i/5xHyOfRIU4nJ5vLcCctbvG on7kyJGvffscFtfi/3bMjX/4OaTJN1ZsZrB6ZGzJnGQbWdn+FcqXX/WPY1VTTlU9QQKI n/nl5QQWIMgZxnNXNLK2T92cSAHkXuXO6lnPQ9Fda45lCndsVCLHlta0MlT3LGLqbJ+3 Srgzl6f8Ke0wyReOofCljpsQxEnD04jeCERQjcpIliRD+GCTPWfBfPZhD2DhHjyWwC8B HJf0L3uuyTF2qIoHP3GbsUCG3i3MVZlPxkYeRRyfJL6sqOA6wbLTuQIb66tYjEbdnAzE Yp+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8rRX4NUebl6MdSW2ICda+smEMgKSJytKBhnJgOF+Chg=; b=K630CfCIic9gpu/4IGQa5/yEt91V3SjsI26Yq8HfdMfvpmTXGXfFqPXATgKxrsn1MO r/Xgs5k56Wr/MiSCWALzeQjVYdOLMp2ezQlmG6EqYcG8dPmxTAKHNWF/3UQQyIShE36Z vx4rCS3K6RWvTELhjOOXHqLvPISbYoRdS3pry6mERCrbvj/eXa4TqrFxNqtTnw2llX7T CQqdH+Eh1e1JJJLXlN5IcNrt8VloIOte0QI5LpuT3agf4S0hBM8uTl2R1Qlr6ndi4A8M 3C26KW1cCF1l2w8YaAdPM0JGJSUQqaTlPRHrX9+u+fMhj32n6RKgFuTH58rseR9EQ991 9rdw== X-Gm-Message-State: AGi0PuYDRO8yLdXAgx7JvcHxvsCEZ1SmympC6ULCMpWdQW/AF0xF70jM 1DYONUx6XD72VH7ETFqyiKVNLiv+5SPiRS4bn+g= X-Google-Smtp-Source: APiQypJ1GCYij/k2S5TY5vBtxTT72Q/SIEJp/72TgqCNDYssop4Of77yIjRQ+YXgKlhz4uQGbJ9yPGZ8cUQ1R+2/RE8= X-Received: by 2002:a7b:c051:: with SMTP id u17mr17683886wmc.129.1586104916518; Sun, 05 Apr 2020 09:41:56 -0700 (PDT) MIME-Version: 1.0 References: <20200403135306.665493-1-berrange@redhat.com> In-Reply-To: From: Aleksandar Markovic Date: Sun, 5 Apr 2020 18:41:35 +0200 Message-ID: Subject: Re: [PATCH v4 for-5.0] configure: warn if not using a separate build directory To: Peter Maydell Content-Type: multipart/alternative; boundary="000000000000202b1c05a28dd4d8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Stefan Hajnoczi , QEMU Developers , Markus Armbruster , Liviu Ionescu , Paolo Bonzini , =?UTF-8?Q?Michal_Such=C3=A1nek?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Aleksandar Markovic Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000202b1c05a28dd4d8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 16:39 Ned, 05.04.2020. Peter Maydell =D1=98=D0= =B5 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0: > > On Fri, 3 Apr 2020 at 14:53, Daniel P. Berrang=C3=A9 wrote: > > > > Running configure directly from the source directory is a build > > configuration that will go away in future. It is also not currently > > covered by any automated testing. Display a deprecation warning if > > the user attempts to use an in-srcdir build setup, so that they are > > aware that they're building QEMU in an undesirable manner. > > > > Reviewed-by: Eric Blake > > Reviewed-by: Markus Armbruster > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > > Tested-by: Philippe Mathieu-Daud=C3=A9 > > Signed-off-by: Daniel P. Berrang=C3=A9 > > --- > > > +if test "$in_srcdir" =3D "yes"; then > > + echo > > + echo "WARNING: SUPPORT FOR BUILDING IN THE SOURCE DIR IS DEPRECATED" > > + echo > > + echo "Support for running the 'configure' script directly from the= " > > + echo "source directory is deprecated. In-tree builds are not covered" > > + echo "by automated testing and thus may not correctly build QEMU." > > + echo "Users are recommended to use a separate build directory:" > > + echo > > + echo " $ mkdir build" > > + echo " $ cd build" > > + echo " $ ../configure" > > + echo " $ make" > > + echo > > +fi > > So here's my stab at some text here; I'm aiming at nudging users > towards out-of-tree builds if they were simply not thinking about > it, but not actively marking them as 'deprecated', since it sounded > to me like we were planning to keep at least the basic > 'configure+make+make install' sequence of commands working. > > echo "NOTE: we recommend against building in the source directory" > echo > echo "You've run the 'configure' script directly from the source" > echo "directory. This will work, but we recommend using a separate" > echo "build directory, especially if you plan to work with the QEMU" > echo "sources rather than just building it once. You can switch to" > echo "a separate build directory like this:" > [instructions go here] > Peter's version is far more superior to Daniel's. I'd better not discuss the reasons, not wanting to waste my time and other's time. For Peter's version: Reviewed-by: Aleksandar Markovic > thanks > -- PMM > --000000000000202b1c05a28dd4d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

16:39 Ned, 05.04.2020. Peter Maydell <peter.maydell@linaro.org> =D1=98=D0=B5 =D0= =BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0:
>
> On Fri, 3 Apr 2020 at 14:53, Daniel P. Berrang=C3=A9 <berrange@redhat.com> wrote:
> >
> > Running configure directly from the source directory is a build > > configuration that will go away in future. It is also not current= ly
> > covered by any automated testing. Display a deprecation warning i= f
> > the user attempts to use an in-srcdir build setup, so that they a= re
> > aware that they're building QEMU in an undesirable manner. > >
> > Reviewed-by: Eric Blake <= eblake@redhat.com>
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
> > Tested-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
> > Signed-off-by: Daniel P. Berrang=C3=A9 <berrange@redhat.com>
> > ---
>
> > +if test "$in_srcdir" =3D "yes"; then
> > +=C2=A0 =C2=A0 echo
> > +=C2=A0 =C2=A0 echo "WARNING: SUPPORT FOR BUILDING IN THE SO= URCE DIR IS DEPRECATED"
> > +=C2=A0 =C2=A0 echo
> > +=C2=A0 =C2=A0 echo "Support for running the 'configure&= #39; script directly from the"
> > +=C2=A0 =C2=A0 echo "source directory is deprecated. In-tree= builds are not covered"
> > +=C2=A0 =C2=A0 echo "by automated testing and thus may not c= orrectly build QEMU."
> > +=C2=A0 =C2=A0 echo "Users are recommended to use a separate= build directory:"
> > +=C2=A0 =C2=A0 echo
> > +=C2=A0 =C2=A0 echo "=C2=A0 $ mkdir build"
> > +=C2=A0 =C2=A0 echo "=C2=A0 $ cd build"
> > +=C2=A0 =C2=A0 echo "=C2=A0 $ ../configure"
> > +=C2=A0 =C2=A0 echo "=C2=A0 $ make"
> > +=C2=A0 =C2=A0 echo
> > +fi
>
> So here's my stab at some text here; I'm aiming at nudging use= rs
> towards out-of-tree builds if they were simply not thinking about
> it, but not actively marking them as 'deprecated', since it so= unded
> to me like we were planning to keep at least the basic
> 'configure+make+make install' sequence of commands working. >
> echo "NOTE: we recommend against building in the source directory= "
> echo
> echo "You've run the 'configure' script directly from= the source"
> echo "directory. This will work, but we recommend using a separat= e"
> echo "build directory, especially if you plan to work with the QE= MU"
> echo "sources rather than just building it once. You can switch t= o"
> echo "a separate build directory like this:"
> [instructions go here]
>

Peter's version is far more superior to Daniel's.

I'd better not discuss the reasons, not wanting to waste= my time and other's time.

For Peter's version:

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

> thanks
> -- PMM
>

--000000000000202b1c05a28dd4d8--