From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: gaosong <gaosong@loongson.cn>
Cc: jiaxun.yang@flygoat.com, qemu-devel@nongnu.org, thomas@t-8ch.de,
xry111@xry111.site, maobibo@loongson.cn
Subject: Re: [PATCH] hw/loongarch: virt: pass random seed to fdt
Date: Mon, 9 Sep 2024 03:41:28 +0200 [thread overview]
Message-ID: <CAHmME9q3CeJ0tPW3QbSEuvRFgQLpgFstEhif5qLGqbMi-R_Ehw@mail.gmail.com> (raw)
In-Reply-To: <73975d81-763b-fe04-5aa9-626a7767a3f0@loongson.cn>
On Mon, Sep 9, 2024 at 3:38 AM gaosong <gaosong@loongson.cn> wrote:
>
>
>
> 在 2024/9/5 下午11:33, Jason A. Donenfeld 写道:
> > If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
> > initialize early. Set this using the usual guest random number
> > generation function.
> >
> > This is the same procedure that's done in b91b6b5a2c ("hw/microblaze:
> > pass random seed to fdt"), e4b4f0b71c ("hw/riscv: virt: pass random seed
> > to fdt"), c6fe3e6b4c ("hw/openrisc: virt: pass random seed to fdt"),
> > 67f7e426e5 ("hw/i386: pass RNG seed via setup_data entry"), c287941a4d
> > ("hw/rx: pass random seed to fdt"), 5e19cc68fb ("hw/mips: boston: pass
> > random seed to fdt"), 6b23a67916 ("hw/nios2: virt: pass random seed to fdt")
> > c4b075318e ("hw/ppc: pass random seed to fdt"), and 5242876f37
> > ("hw/arm/virt: dt: add rng-seed property").
> >
> > These earlier commits later were amended to rerandomize the RNG seed on
> > snapshot load, but the LoongArch code somehow already does that, despite
> > not having this patch here, presumably due to some lucky copy and
> > pasting.
> >
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > ---
> > hw/loongarch/virt.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
>
> Reviewed-by: Song Gao <gaosong@loongson.cn>
Do you generally queue these up in
https://gitlab.com/gaosong/qemu/-/commits/loongarch-next/?ref_type=heads
? Or is it a different branch?
next prev parent reply other threads:[~2024-09-09 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 15:33 [PATCH] hw/loongarch: virt: pass random seed to fdt Jason A. Donenfeld
2024-09-09 1:38 ` gaosong
2024-09-09 1:41 ` Jason A. Donenfeld [this message]
2024-09-09 1:52 ` gaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9q3CeJ0tPW3QbSEuvRFgQLpgFstEhif5qLGqbMi-R_Ehw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=thomas@t-8ch.de \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).