From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: linux-m68k@lists.linux-m68k.org, qemu-devel@nongnu.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes
Date: Mon, 26 Sep 2022 23:42:37 +0200 [thread overview]
Message-ID: <CAHmME9qFuKwUKvqOZZMuy8v+SLBh1Dt5+5xRM=+v6ynGktbj8g@mail.gmail.com> (raw)
In-Reply-To: <5ebf4a4a-031b-0706-d199-d116cd518226@vivier.eu>
On Mon, Sep 26, 2022 at 11:42 PM Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit :
> > On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier <laurent@vivier.eu> wrote:
> >>
> >> Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit :
> >>> Various tools, such as kexec-tools and m68k-bootinfo, expect each
> >>> bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the
> >>> padding to fill this out as such.
> >>>
> >>> Also, break apart the padding additions from the other field length
> >>> additions, so that it's more clear why these magic numbers are being
> >>> added, and comment them too.
> >>>
> >>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >>> Cc: Laurent Vivier <laurent@vivier.eu>
> >>> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> >>> ---
> >>> hw/m68k/bootinfo.h | 10 ++++++----
> >>> 1 file changed, 6 insertions(+), 4 deletions(-)
> >>>
> >>
> >> Applied to my m68k-for-7.2 branch
> >
> > What about 1/2?
> >
>
> I'd like to wait a little to see what happens on the linux side.
Alright, makes sense. Just please don't forget about it.
Jason
next prev parent reply other threads:[~2022-09-26 21:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 11:38 [PATCH qemu v2 1/2] m68k: rework BI_VIRT_RNG_SEED as BI_RNG_SEED Jason A. Donenfeld
2022-09-26 11:39 ` [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes Jason A. Donenfeld
2022-09-26 13:00 ` Laurent Vivier
2022-09-26 21:37 ` Laurent Vivier
2022-09-26 21:40 ` Jason A. Donenfeld
2022-09-26 21:42 ` Laurent Vivier
2022-09-26 21:42 ` Jason A. Donenfeld [this message]
2022-09-28 23:13 ` Jason A. Donenfeld
2022-09-29 6:37 ` [PATCH qemu v2 1/2] m68k: rework BI_VIRT_RNG_SEED as BI_RNG_SEED Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qFuKwUKvqOZZMuy8v+SLBh1Dt5+5xRM=+v6ynGktbj8g@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).