From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Roman Kiryanov <rkir@google.com>
Cc: philmd@linaro.org, manos.pitsidianakis@linaro.org,
qemu-devel@nongnu.org, whollins@google.com, jansene@google.com,
jpcottin@google.com
Subject: Re: [PATCH 0/3] virtio-snd: snapshot prep cleanups
Date: Wed, 25 Mar 2026 12:48:28 +0400 [thread overview]
Message-ID: <CAJ+F1C+RpfArHJBi_KdGjuUro=+GVn-=AnKjTJj07s3ocg1cPA@mail.gmail.com> (raw)
In-Reply-To: <20260310235632.3987668-1-rkir@google.com>
Hi
On Wed, Mar 11, 2026 at 3:57 AM Roman Kiryanov <rkir@google.com> wrote:
>
> I am currently working on adding snapshot support for the virtio-snd
> device. While implementing the VMStateDescription, I noticed that the
> device currently retains more internal state than is strictly necessary,
> including unused fields and full transport-specific layouts.
>
> This patch series cleans up the internal PCM state to reduce the overall
> allocation footprint and simplify the upcoming snapshotting and migration
> handling code.
>
> Roman Kiryanov (3):
> virtio-snd: remove the unused field
> virtio-snd: remove virtio_snd_pcm_set_params from VirtIOSoundPCMStream
> virtio-snd: introduce VirtIOPcmParams
>
> hw/audio/virtio-snd.c | 21 +++++++++------------
> include/hw/audio/virtio-snd.h | 17 +++++++++++++----
> 2 files changed, 22 insertions(+), 16 deletions(-)
For the series:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau
prev parent reply other threads:[~2026-03-25 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 23:56 [PATCH 0/3] virtio-snd: snapshot prep cleanups Roman Kiryanov
2026-03-10 23:56 ` [PATCH 1/3] virtio-snd: remove the unused field Roman Kiryanov
2026-03-10 23:56 ` [PATCH 2/3] virtio-snd: remove virtio_snd_pcm_set_params from VirtIOSoundPCMStream Roman Kiryanov
2026-03-10 23:56 ` [PATCH 3/3] virtio-snd: introduce VirtIOPcmParams Roman Kiryanov
2026-03-24 21:04 ` [PATCH 0/3] virtio-snd: snapshot prep cleanups Roman Kiryanov
2026-03-25 8:48 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1C+RpfArHJBi_KdGjuUro=+GVn-=AnKjTJj07s3ocg1cPA@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
--cc=whollins@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox