From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMEZ-00069J-2O for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:58:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUMEY-0002kn-DR for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:58:23 -0400 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:33214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMEY-0002kf-9E for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:58:22 -0400 Received: by oieu205 with SMTP id u205so39642637oie.0 for ; Tue, 25 Aug 2015 14:58:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150825171138.11069.51537@loki> References: <1435751267-26378-1-git-send-email-marcandre.lureau@gmail.com> <1435751267-26378-11-git-send-email-marcandre.lureau@gmail.com> <20150825171138.11069.51537@loki> Date: Tue, 25 Aug 2015 23:58:21 +0200 Message-ID: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/12] qga: add --dump-conf option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: QEMU On Tue, Aug 25, 2015 at 7:11 PM, Michael Roth w= rote: > I think we're missing fsfreeze_hook option here. > good catch > To me it seems cleaner to actually create the GKeyFile from current > options, then let GLib do all the work of generation a config file > we can spit out (g_key_file_to_data() should do it i think). I don't mind, why not. > That, paired with the idea of having a GAConfig structure to > encapulate all the config options, might warrant restructuring > things a bit so that we have a > gkeyfile_to_gaconfig()/gkeyfile_from_gaconfig() pair to use for > reading/dumping configs while keeping all the options in an > easily trackable place. --=20 Marc-Andr=C3=A9 Lureau