From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2040AC433E0 for ; Thu, 28 Jan 2021 19:30:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BE9E64E30 for ; Thu, 28 Jan 2021 19:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BE9E64E30 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5D0C-00087q-04 for qemu-devel@archiver.kernel.org; Thu, 28 Jan 2021 14:30:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5CyX-0007dJ-Es for qemu-devel@nongnu.org; Thu, 28 Jan 2021 14:29:05 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:44659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5CyV-0003gx-UE for qemu-devel@nongnu.org; Thu, 28 Jan 2021 14:29:05 -0500 Received: by mail-ed1-x531.google.com with SMTP id c2so7935892edr.11 for ; Thu, 28 Jan 2021 11:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cjxLwpKeTpDXhCpqh/aYtxOL72HZi04kzKRymafej3c=; b=QqddcPOVDWtePZj3wjp0OECsm9G+66Rf5sAQq6+H4sWY5Getv9K1RMJ9DKPgT8bWzC 3499R9FJYMdiRm+bAERtfxu+VXZjzXxUfMxQ43ZuTMmoT/N71ckQ8rSewIaUG+Tgz0KY hOh+A7+46coMQQ/DlbLiV1xa9cFQXUO9II+BJ6H9mUx/eRGraLuVzCwJdWCYmBFJqgUn gIdN5OBmfmNBphAgE0fFygdjModztYJ59fQEILYX8OQl+5JOmAuwyhzAa+nc2XhSVER5 h9DKj5jkx58wzU4PMZGoR+LpIsXAk3aGmUXRdu7+psWICfL6sJ+c8cUjvR7B9mh3xlri DJBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cjxLwpKeTpDXhCpqh/aYtxOL72HZi04kzKRymafej3c=; b=Bq0OCjes2s4/ik932qgdDxGjx1gA4tH/eo6w3n0zQjzJUo3aL+RB9mwkS6l2ZHNDZ6 pjvqQ4mjK7cd5wCmT4rZH5D9skXGOLMCvliwNFFZfgBcDxiqQNOa9AoOQba15m4oeZ/r kXE9y3GH67I6mIyEJO3/vt2JeAci0N4cbBlQBg7K9RyFq4W9DkSGU5T2wsjxi3XwZDZb 2ahOdrtaF2jkn9IBrzan2TDCjOH8cf/YFWZDF5KdqkAx/f5MM+BHJ4dgosAzMGkOdbKx jnwiCmrBBAuojXEqlBOHuQL+Wooxy+VFIolv73D0uoAUodScxsGjpHq6qItp7q74jw+3 jqpw== X-Gm-Message-State: AOAM531UQFaxF0ruLDEl6OtvPtf5PatGuVPNsad65xyis3q7rieDtAXh ZKJABwDyNLnHZzw+2OEPvk4iAgyucbkOmp9rwJM= X-Google-Smtp-Source: ABdhPJwu5ehjf/yMDAM+Mz3DcmiRXPfjweq75xUSb5HPdODhb+2pdlAABQiBvTRuoqqWcGCeco0NNv+Piu1yzfYyiuU= X-Received: by 2002:a05:6402:1682:: with SMTP id a2mr1363739edv.30.1611862142199; Thu, 28 Jan 2021 11:29:02 -0800 (PST) MIME-Version: 1.0 References: <20210128111319.329755-1-marcandre.lureau@redhat.com> <20210128114352.tvwnx435qbqcv4a4@sirius.home.kraxel.org> <20210128142625.vzdrehzw6mufja3s@sirius.home.kraxel.org> <20210128144202.2pqjjn3epspfvlgk@sirius.home.kraxel.org> <20210128163426.lsd2y3w7htovfnfx@sirius.home.kraxel.org> In-Reply-To: <20210128163426.lsd2y3w7htovfnfx@sirius.home.kraxel.org> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 28 Jan 2021 23:28:50 +0400 Message-ID: Subject: Re: [PATCH] spice: delay starting until display are initialized To: Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Bonzini, Paolo" , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 28, 2021 at 8:34 PM Gerd Hoffmann wrote: > > Hi, > > > > So move the vmstate handler registration call too? > > > I'd prefer to not add more state variables if we can avoid it ... > > > > Does that seem right to you? > > > @@ -626,7 +625,7 @@ static int add_channel(void *opaque, const char > > *name, const char *value, > > static void vm_change_state_handler(void *opaque, int running, > > RunState state) > > { > > - if (running && spice_display_init_done) { > > + if (running) { > > qemu_spice_display_start(); > > } else if (state !=3D RUN_STATE_PAUSED) { > > qemu_spice_display_stop(); > > @@ -635,7 +634,7 @@ static void vm_change_state_handler(void *opaque, > > int running, > > > > void qemu_spice_display_init_done(void) > > { > > - spice_display_init_done =3D true; > > + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); > > vm_change_state_handler(NULL, runstate_is_running(), runstate_get(= )); > > I'd just call qemu_spice_display_start() directly here, the need for > runstate_get() goes away then. Otherwise looks good to me. Hmm, that could work, but it will behave differently as we will start spice even if the VM is not running then. --=20 Marc-Andr=C3=A9 Lureau