qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Dorinda Bassey <dbassey@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, armbru@redhat.com,
	 qemu_oss@crudebyte.com, pbonzini@redhat.com,
	wtaymans@redhat.com
Subject: Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU
Date: Tue, 7 Mar 2023 17:49:10 +0400	[thread overview]
Message-ID: <CAJ+F1CJRXdiv=Denf-q7cQ=X39MQL8X=_4Zf7aB5ozPCGJDY9A@mail.gmail.com> (raw)
In-Reply-To: <CACzuRyxMSnJ9ANgQT+Vt1SK3ETt=TtvtKsA2GNzEpe=AQ6iApQ@mail.gmail.com>

Hi

On Fri, Mar 3, 2023 at 8:06 PM Dorinda Bassey
>> What are those thread_loop_signal() for? Maybe leave a comment?
>
> the explanation of the function is in the reference header file.
>

Yes, I read the reference documentation before asking: "Signal all
threads waiting with pw_thread_loop_wait."
(https://docs.pipewire.org/group__pw__thread__loop.html#gaf9bc8dd348d05b095139f5a55ac5a4b0)

Unfortunately, you are not calling pw_thread_loop_wait yourself, so
that doesn't help me what this is supposed to do. When signaling
things and expecting a certain state and side-effect from a different
thread or context, it's nice to document it.

I guess this will break the thread loop? What happens next?

thanks

-- 
Marc-André Lureau


  reply	other threads:[~2023-03-07 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 21:59 [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU Dorinda Bassey
2023-03-01 11:08 ` Marc-André Lureau
2023-03-03 16:05   ` Dorinda Bassey
2023-03-07 13:49     ` Marc-André Lureau [this message]
2023-03-08 16:13       ` Dorinda Bassey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+F1CJRXdiv=Denf-q7cQ=X39MQL8X=_4Zf7aB5ozPCGJDY9A@mail.gmail.com' \
    --to=marcandre.lureau@gmail.com \
    --cc=armbru@redhat.com \
    --cc=dbassey@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=wtaymans@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).