From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fif1n-0004Jk-MF for qemu-devel@nongnu.org; Thu, 26 Jul 2018 08:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fif1k-0001mu-LV for qemu-devel@nongnu.org; Thu, 26 Jul 2018 08:05:55 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:42820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fif1k-0001l4-EI for qemu-devel@nongnu.org; Thu, 26 Jul 2018 08:05:52 -0400 Received: by mail-wr1-x443.google.com with SMTP id e7-v6so1458228wrs.9 for ; Thu, 26 Jul 2018 05:05:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180726120408.GA6511@vader> References: <20180725141610.12075-1-otubo@redhat.com> <20180726120408.GA6511@vader> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 26 Jul 2018 14:05:50 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/2] seccomp branch queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: Peter Maydell , QEMU Developers H On Thu, Jul 26, 2018 at 2:04 PM, Eduardo Otubo wrote: > On 26/07/2018 - 11:47:46, Peter Maydell wrote: >> On 25 July 2018 at 15:16, Eduardo Otubo wrote: >> > The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca= 5f4cc: >> > >> > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) >> > >> > are available in the Git repository at: >> > >> > https://github.com/otubo/qemu.git tags/pull-seccomp-20180725 >> > >> > for you to fetch changes up to 5b2f59307372bae13a2ff95706646674eccb65e= 0: >> > >> > RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available (2018-07-25 = 16:07:31 +0200) >> > >> > ---------------------------------------------------------------- >> > pull-seccomp-20180725 >> > >> > ---------------------------------------------------------------- >> > Marc-Andr=C3=A9 Lureau (2): >> > seccomp: use SIGSYS signal instead of killing the thread >> > RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available >> >> Hi. This fails to compile with clang: >> >> CC qemu-seccomp.o >> qemu-seccomp.c:112:1: error: unused function 'qemu_seccomp' >> [-Werror,-Wunused-function] >> qemu_seccomp(unsigned int operation, unsigned int flags, void *args) >> ^ >> >> This is because clang is stricter about warning about static inline >> functions defined in .c files but never used and your ifdef >> guard on the callsite is not matched by one around the function >> definition. >> > > Peter, sorry for not catching that before. > Marc, can you fix and resend? I suggest to drop that patch from 3.0. Since it will require a newer libseccomp to be actually useful, it can be delayed imho. --=20 Marc-Andr=C3=A9 Lureau