From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, den@virtuozzo.com, michael.roth@amd.com,
kkostiuk@redhat.com
Subject: Re: [PATCH 4/7] qga: Add shutdown/halt/reboot support for FreeBSD
Date: Thu, 29 Sep 2022 15:28:51 +0400 [thread overview]
Message-ID: <CAJ+F1CL8FyK65xrFrMa890fxe2tc8D=m0SkPCAkaxXYRVf+FXg@mail.gmail.com> (raw)
In-Reply-To: <20220929075239.1675374-5-alexander.ivanov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]
On Thu, Sep 29, 2022 at 1:02 PM Alexander Ivanov <
alexander.ivanov@virtuozzo.com> wrote:
> Add appropriate shutdown command arguments to qmp_guest_shutdown()
> for FreeBSD.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 49f9996a9c..88e0d0fe24 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -90,6 +90,10 @@ void qmp_guest_shutdown(bool has_mode, const char
> *mode, Error **errp)
> const char *powerdown_flag = "-i5";
> const char *halt_flag = "-i0";
> const char *reboot_flag = "-i6";
> +#elif defined(CONFIG_BSD)
> + const char *powerdown_flag = "-p";
> + const char *halt_flag = "-h";
> + const char *reboot_flag = "-r";
> #else
> const char *powerdown_flag = "-P";
> const char *halt_flag = "-H";
> @@ -120,6 +124,9 @@ void qmp_guest_shutdown(bool has_mode, const char
> *mode, Error **errp)
> #ifdef CONFIG_SOLARIS
> execl("/sbin/shutdown", "shutdown", shutdown_flag, "-g0", "-y",
> "hypervisor initiated shutdown", (char *)NULL);
> +#elif defined(CONFIG_BSD)
> + execl("/sbin/shutdown", "shutdown", shutdown_flag, "+0",
> + "hypervisor initiated shutdown", (char *)NULL);
> #else
> execl("/sbin/shutdown", "shutdown", "-h", shutdown_flag, "+0",
> "hypervisor initiated shutdown", (char *)NULL);
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2695 bytes --]
next prev parent reply other threads:[~2022-09-29 12:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 7:52 [PATCH v2 0/7] qga: Add FreeBSD support Alexander Ivanov
2022-09-29 7:52 ` [PATCH 1/7] qga: Add initial " Alexander Ivanov
2022-09-29 11:29 ` Marc-André Lureau
2022-09-29 14:11 ` Alexander Ivanov
2022-09-29 7:52 ` [PATCH 2/7] qga: Move Linux-specific FS freeze/thaw code to a separate file Alexander Ivanov
2022-09-29 11:29 ` Marc-André Lureau
2022-09-29 7:52 ` [PATCH 3/7] qga: Add UFS freeze/thaw support for FreeBSD Alexander Ivanov
2022-09-29 11:28 ` Marc-André Lureau
2022-09-29 7:52 ` [PATCH 4/7] qga: Add shutdown/halt/reboot " Alexander Ivanov
2022-09-29 11:28 ` Marc-André Lureau [this message]
2022-09-29 7:52 ` [PATCH 5/7] qga: Add support for user password setting in FreeBSD Alexander Ivanov
2022-09-29 11:22 ` Marc-André Lureau
2022-09-29 14:29 ` Alexander Ivanov
2022-09-30 8:19 ` Marc-André Lureau
2022-09-30 13:11 ` Alexander Ivanov
2022-09-29 7:52 ` [PATCH 6/7] qga: Move HW address getting to a separate function Alexander Ivanov
2022-09-29 11:28 ` Marc-André Lureau
2022-09-29 14:33 ` Alexander Ivanov
2022-09-29 7:52 ` [PATCH 7/7] qga: Add HW address getting for FreeBSD Alexander Ivanov
2022-09-29 11:28 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CL8FyK65xrFrMa890fxe2tc8D=m0SkPCAkaxXYRVf+FXg@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).