From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1ZUMGl-00012M-41
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 18:00:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1ZUMGk-00047S-Cc
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 18:00:39 -0400
Received: from mail-ob0-x22d.google.com ([2607:f8b0:4003:c01::22d]:35757)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1ZUMGk-00047M-8c
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 18:00:38 -0400
Received: by obbwr7 with SMTP id wr7so155221766obb.2
	for <qemu-devel@nongnu.org>; Tue, 25 Aug 2015 15:00:37 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20150825155502.11069.59278@loki>
References: <1435751267-26378-1-git-send-email-marcandre.lureau@gmail.com>
	<1435751267-26378-5-git-send-email-marcandre.lureau@gmail.com>
	<20150825155502.11069.59278@loki>
Date: Wed, 26 Aug 2015 00:00:37 +0200
Message-ID: <CAJ+F1CLRB6RxxRffdZC8aZGtiB7OsPGyUsQAT3GiY8AR6KmkcA@mail.gmail.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 04/12] qga: rename 'path' to 'device_path'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: QEMU <qemu-devel@nongnu.org>

hi

On Tue, Aug 25, 2015 at 5:55 PM, Michael Roth <mdroth@linux.vnet.ibm.com> w=
rote:
> Quoting Marc-Andr=C3=A9 Lureau (2015-07-01 06:47:39)
>> 'path' is already a global function, rename the variable since it's
>> going to be in global scope in a later patch.
>>
>> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@gmail.com>
>
> I think I'd prefer something like 'channel_path' since we support
> sockets as well. Looks good otherwise.


ok, done

--=20
Marc-Andr=C3=A9 Lureau