From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tcg/tcg-op.h: Add multiple include guard
Date: Thu, 8 Nov 2018 16:57:47 +0400 [thread overview]
Message-ID: <CAJ+F1CLW93jHocJMG+=sXkMzTyyHdh2-XdJbc0sGdK5XboUtyA@mail.gmail.com> (raw)
In-Reply-To: <20181108125256.30986-1-peter.maydell@linaro.org>
On Thu, Nov 8, 2018 at 4:53 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The tcg-op.h header was missing the usual guard against multiple
> inclusion; add it.
>
> (Spotted by lgtm.com's static analyzer.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tcg/tcg-op.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index 7513c1eb7c5..db4e9188f42 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -22,6 +22,9 @@
> * THE SOFTWARE.
> */
>
> +#ifndef TCG_TCG_OP_H
> +#define TCG_TCG_OP_H
> +
> #include "tcg.h"
> #include "exec/helper-proto.h"
> #include "exec/helper-gen.h"
> @@ -1267,3 +1270,5 @@ static inline void tcg_gen_trunc_ptr_i32(TCGv_i32 r, TCGv_ptr a)
>
> #undef PTR
> #undef NAT
> +
> +#endif /* TCG_TCG_OP_H */
> --
> 2.19.1
>
>
--
Marc-André Lureau
next prev parent reply other threads:[~2018-11-08 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 12:52 [Qemu-devel] [PATCH] tcg/tcg-op.h: Add multiple include guard Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau [this message]
2018-11-08 13:08 ` Philippe Mathieu-Daudé
2018-11-08 13:17 ` Peter Maydell
2018-11-08 14:08 ` Philippe Mathieu-Daudé
2018-11-08 13:39 ` Richard Henderson
2018-11-08 15:53 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CLW93jHocJMG+=sXkMzTyyHdh2-XdJbc0sGdK5XboUtyA@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).