From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bmG2C-0005om-FE
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 04:04:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bmG28-0005oo-EK
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 04:04:08 -0400
Received: from mail-lf0-f65.google.com ([209.85.215.65]:36595)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bmG28-0005oj-6H
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 04:04:04 -0400
Received: by mail-lf0-f65.google.com with SMTP id s29so470312lfg.3
	for <qemu-devel@nongnu.org>; Tue, 20 Sep 2016 01:04:04 -0700 (PDT)
MIME-Version: 1.0
References: <20160919155139.28371-1-alex.bennee@linaro.org>
	<20160919155139.28371-3-alex.bennee@linaro.org>
In-Reply-To: <20160919155139.28371-3-alex.bennee@linaro.org>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Date: Tue, 20 Sep 2016 08:02:53 +0000
Message-ID: <CAJ+F1CLee9Z33mq0kNnt+Xztu7m+xrvXqsFUgQU8m6E_DBGuMg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 2/8] tcg/optimize: move default return out of
 if statement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org, pbonzini@redhat.com, cota@braap.org, stefanha@redhat.com, kwolf@redhat.com
Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, nikunj@linux.vnet.ibm.com, jan.kiszka@siemens.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, serge.fdrv@gmail.com, bobby.prani@gmail.com, rth@twiddle.net, fred.konrad@greensocs.com

On Mon, Sep 19, 2016 at 7:56 PM Alex Benn=C3=A9e <alex.bennee@linaro.org> w=
rote:

> This is to appease sanitizer builds which complain that:
>
>   "error: control reaches end of non-void function"
>
> Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
>

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>


> ---
>  tcg/optimize.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 9998ac7..0f13490 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op,
> TCGArg x,
>          default:
>              return 2;
>          }
> -    } else {
> -        return 2;
>      }
> +    return 2;
>  }
>
>  /* Return 2 if the condition can't be simplified, and the result
> --
> 2.9.3
>
>
> --
Marc-Andr=C3=A9 Lureau