From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Doug Evans <dje@google.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support
Date: Thu, 4 Feb 2021 20:40:58 +0400 [thread overview]
Message-ID: <CAJ+F1CLmvcEOOYh7puPEHwzVWrbVV72fdi+MBw3w2T+GHLu4zQ@mail.gmail.com> (raw)
In-Reply-To: <20210203233539.1990032-2-dje@google.com>
Hi,
On Thu, Feb 4, 2021 at 3:38 AM dje--- via <qemu-devel@nongnu.org> wrote:
>
> This commit is intended to only contain the slirp submodule change
> that adds ipv6 hostfwd support.
> ---
> slirp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
It's generally recommended to include the shortlog of some sort in the
commit message of what changed between the two commits, ex:
https://patchew.org/QEMU/20210125073427.3970606-1-marcandre.lureau@redhat.com/20210125073427.3970606-2-marcandre.lureau@redhat.com/
thanks
> diff --git a/slirp b/slirp
> index 8f43a99191..358c0827d4 160000
> --- a/slirp
> +++ b/slirp
> @@ -1 +1 @@
> -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> +Subproject commit 358c0827d49778f016312bfb4167fe639900681f
> --
> 2.30.0.365.g02bc693789-goog
>
>
--
Marc-André Lureau
next prev parent reply other threads:[~2021-02-04 17:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:35 [PATCH v3 0/3] dje--- via
2021-02-03 23:35 ` [PATCH v3 1/3] slirp: Placeholder for libslirp ipv6 hostfwd support dje--- via
2021-02-04 16:02 ` Eric Blake
2021-02-04 16:40 ` Doug Evans
2021-02-04 16:40 ` Marc-André Lureau [this message]
2021-02-03 23:35 ` [PATCH v3 2/3] net/slirp.c: Refactor address parsing dje--- via
2021-02-03 23:35 ` [PATCH v3 3/3] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands dje--- via
2021-02-03 23:45 ` [PATCH v3 0/3] no-reply
2021-02-04 10:03 ` Daniel P. Berrangé
2021-02-04 18:25 ` Doug Evans
2021-02-10 2:16 ` Doug Evans
2021-02-10 9:31 ` Daniel P. Berrangé
2021-02-10 16:31 ` Doug Evans
2021-02-10 16:49 ` Daniel P. Berrangé
2021-02-10 22:40 ` Doug Evans
2021-02-11 9:12 ` Daniel P. Berrangé
2021-02-18 20:30 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+F1CLmvcEOOYh7puPEHwzVWrbVV72fdi+MBw3w2T+GHLu4zQ@mail.gmail.com \
--to=marcandre.lureau@gmail.com \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).