From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D5FC07E96 for ; Sun, 11 Jul 2021 17:26:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CEC761151 for ; Sun, 11 Jul 2021 17:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CEC761151 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2dEF-0000Ua-QC for qemu-devel@archiver.kernel.org; Sun, 11 Jul 2021 13:26:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2d6k-0005m6-3B for qemu-devel@nongnu.org; Sun, 11 Jul 2021 13:19:11 -0400 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:42630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2d6i-00010D-BD for qemu-devel@nongnu.org; Sun, 11 Jul 2021 13:19:09 -0400 Received: by mail-yb1-xb30.google.com with SMTP id o139so24267296ybg.9 for ; Sun, 11 Jul 2021 10:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=az4x/NZQPedt9oyyzTiOfa/v1AM4VnIkb/fpSblOvOU=; b=indUt9uj48vr8zSIwmgSzljkISLvBkQS7MnxeN44nkhkINuhHTdKAWGuEUcXH6CJv2 zGort0WoxQL8Sf0SUVjN5+w/7Tjh/naJa8y2lRra1gYcEgZTwmMoWgWUWtDo++I0brs3 xHuTjWVeapJQzbBbCAuIubQOb7DV7bNmeg3cx/Biy+bQTiCRg05lGLGlX6RI8Z/Ewbwb tY3RNL++SLD5edqvzZfULuD2YsJyYsXm1ckx8Ni+vEUoINWaA9pHwX3nramxO8suQ856 ph0tB5uU9oMNwtduBoK/k0x2vz0YEzbpoGA+EMr/q4Km6WLJEserYwADk7kktRiNnLBW DO5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=az4x/NZQPedt9oyyzTiOfa/v1AM4VnIkb/fpSblOvOU=; b=mtGDwXHaO9RrPDiGKyqKEtg24mXf/v0Mb8hVPRHO6VaE41wLeUgo7GtDss26q0KNFS oleue0vT3fqri/hn169/YArV/4nVaxWQuBWZrk0H8/sWZFYeENZWwTZWkK1BSigHVkm0 OUb5MkXu/xX0jd+u8wSik2FAxWSw+xCDTXP5AnVkv12nXtMnPuiuplATzdKC1dj7FBpO h6uL7wxYaSJH2/auI0fncRylQBBiODTB0U9da6tVv8Ap/vWWJcsop220cMgDr3hp0nGC l+9wHPIQ8EHT5gJWUlMXyrWNjgjoss83G5ahCb9nA0eMREuAuRsEQg/LkqTmIHAV0P8I oPzg== X-Gm-Message-State: AOAM533MpnselujtMxxxPvAE7DlgpbrPD2Qi0H+YjWnTR5pPCIvPZqB6 uCoVSDBJ5OrNKc/94fUwxexYAIcMS6HvCI8hzIe2Y5Esu4s= X-Google-Smtp-Source: ABdhPJyhMJF+3qhYPZgYaTbcpMfMnIVmqoVtnBDZhEctctVKlF1+KiYJQLv3sF5EUgPRwGrewXpOsHRyL30MSfw4ozM= X-Received: by 2002:a25:80d4:: with SMTP id c20mr59591713ybm.345.1626023947477; Sun, 11 Jul 2021 10:19:07 -0700 (PDT) MIME-Version: 1.0 References: <20210405131420.598273-1-basil@daynix.com> In-Reply-To: From: Konstantin Kostiuk Date: Sun, 11 Jul 2021 20:18:56 +0300 Message-ID: Subject: Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10 To: Developers Content-Type: multipart/alternative; boundary="000000000000c9360c05c6dc3380" Received-SPF: none client-ip=2607:f8b0:4864:20::b30; envelope-from=konstantin@daynix.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000c9360c05c6dc3380 Content-Type: text/plain; charset="UTF-8" ping On Sun, Jul 4, 2021 at 8:52 AM Konstantin Kostiuk wrote: > ping > > On Mon, Apr 5, 2021 at 4:14 PM Basil Salman wrote: > >> Currently Requester freeze times out after 10 seconds, while >> the default timeout for Writer Freeze is 60 seconds. according to >> VSS Documentation [1]. >> [1]: >> https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-backup-under-vss >> >> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1909073 >> >> Signed-off-by: Basil Salman >> Signed-off-by: Basil Salman >> --- >> qga/vss-win32/requester.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp >> index 5378c55d23..940a2c8f55 100644 >> --- a/qga/vss-win32/requester.cpp >> +++ b/qga/vss-win32/requester.cpp >> @@ -18,7 +18,7 @@ >> #include >> >> /* Max wait time for frozen event (VSS can only hold writes for 10 >> seconds) */ >> -#define VSS_TIMEOUT_FREEZE_MSEC 10000 >> +#define VSS_TIMEOUT_FREEZE_MSEC 60000 >> >> /* Call QueryStatus every 10 ms while waiting for frozen event */ >> #define VSS_TIMEOUT_EVENT_MSEC 10 >> -- >> 2.17.2 >> >> --000000000000c9360c05c6dc3380 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
ping

On Sun, Jul 4, 2021 at 8:52 AM Konstantin Kostiuk = <konstantin@daynix.com> = wrote:
ping

On Mon, Apr 5, 2021 at 4:14 PM Basil Salman <basil@daynix.com> w= rote:
Currently = Requester freeze times out after 10 seconds, while
the default timeout for Writer Freeze is 60 seconds. according to
VSS Documentation [1].
[1]: htt= ps://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-ba= ckup-under-vss

Buglink: https://bugzilla.redhat.com/show_bug.c= gi?id=3D1909073

Signed-off-by: Basil Salman <bsalman@daynix.com>
Signed-off-by: Basil Salman <basil@daynix.com>
---
=C2=A0qga/vss-win32/requester.cpp | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 5378c55d23..940a2c8f55 100644
--- a/qga/vss-win32/requester.cpp
+++ b/qga/vss-win32/requester.cpp
@@ -18,7 +18,7 @@
=C2=A0#include <inc/win2003/vsbackup.h>

=C2=A0/* Max wait time for frozen event (VSS can only hold writes for 10 se= conds) */
-#define VSS_TIMEOUT_FREEZE_MSEC 10000
+#define VSS_TIMEOUT_FREEZE_MSEC 60000

=C2=A0/* Call QueryStatus every 10 ms while waiting for frozen event */
=C2=A0#define VSS_TIMEOUT_EVENT_MSEC 10
--
2.17.2

--000000000000c9360c05c6dc3380--