From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pradeepkiruvale@gmail.com>) id 1c9CaS-0000g7-Kx
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 10:02:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pradeepkiruvale@gmail.com>) id 1c9CaM-0008PV-WE
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 10:02:20 -0500
MIME-Version: 1.0
In-Reply-To: <20161122145547.0549ae27@bahia>
References: <147981681351.30309.4854065801791462661.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
	<w51twazlj1r.fsf@maestria.local.igalia.com>
	<20161122145547.0549ae27@bahia>
From: Pradeep Kiruvale <pradeepkiruvale@gmail.com>
Date: Tue, 22 Nov 2016 16:02:12 +0100
Message-ID: <CAJ2SuLmWg29m07ynVMNi2DrnChGpdDwtUknhDb1NKrRMVUeQJA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline
 options to a separate header file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <groug@kaod.org>
Cc: Alberto Garcia <berto@igalia.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>

On 22 November 2016 at 14:55, Greg Kurz <groug@kaod.org> wrote:

> On Tue, 22 Nov 2016 14:51:12 +0100
> Alberto Garcia <berto@igalia.com> wrote:
>
> > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote:
> >
> > > This will allow other subsystems (i.e. fsdev) to implement throttling
> > > without duplicating the command line options.
> > >
> > > Signed-off-by: Greg Kurz <groug@kaod.org>
> >
> > Did you check if it's possible / easy to do defining a normal array
> > instead of a macro and using qemu_opts_append() or something similar?
> >
> > Berto
>
> No I didn't due to lack of time but maybe Pradeep may have a look in this
> direction ?
>

Only may be next year :)

-Pradeep


>
> Cheers.
>
> --
> Greg
>