From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pradeepkiruvale@gmail.com>) id 1btaBu-0004BO-RZ
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:00:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pradeepkiruvale@gmail.com>) id 1btaBp-00022q-Hr
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 09:00:25 -0400
MIME-Version: 1.0
In-Reply-To: <CAJ2SuL=cPy3YPgE=nvHwhiWdOZwwgiAiE-ONUjqBy_9LCA099w@mail.gmail.com>
References: <CAJ2SuLkvuOtUFHk0mk-hCTt+8Y8WVGqM7HF9ZBcSMewh4i2Y5w@mail.gmail.com>
	<20160928082911.GB4196@stefanha-x1.localdomain>
	<CAJ2SuLmpV76F1c_uaWPTCrrLFRTfuNs29A75jPTN37CCwmPH+g@mail.gmail.com>
	<20160930134921.GJ24982@stefanha-x1.localdomain>
	<CAJ2SuL=cPy3YPgE=nvHwhiWdOZwwgiAiE-ONUjqBy_9LCA099w@mail.gmail.com>
From: Pradeep Kiruvale <pradeepkiruvale@gmail.com>
Date: Mon, 10 Oct 2016 15:00:20 +0200
Message-ID: <CAJ2SuLmuwA421mWriqKn6M59-Gcr6R7ho5dvyiYTXNbZPTzA2g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] Virtio-net cli parameters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "qemu-discuss@nongnu.org" <qemu-discuss@nongnu.org>

On 10 October 2016 at 11:26, Pradeep Kiruvale <pradeepkiruvale@gmail.com>
wrote:

> Hi Stefan,
>
> Thanks for the reply.
>
> On 30 September 2016 at 15:49, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
>> On Thu, Sep 29, 2016 at 04:11:27PM +0200, Pradeep Kiruvale wrote:
>> > Hi Stefan,
>> >
>> > On 28 September 2016 at 10:29, Stefan Hajnoczi <stefanha@gmail.com>
>> wrote:
>> >
>> > > On Mon, Sep 26, 2016 at 05:41:55PM +0200, Pradeep Kiruvale wrote:
>> > > > I want to add couple of new cli options for the virtio-net driver
>> and use
>> > > > them inside the
>> > > > virtio-net driver to throttle the packets. I did go through the
>> code and
>> > > > did single stepping
>> > > > using the gdb, but still could not find the place where the
>> virtio-net
>> > > > parameters are getting
>> > > > parsed and populated into the virtio-net structures.
>> > > > Could some one please guide/suggest where to look into, in qemu code
>> > > base?
>> > >
>> > > Take a look at virtio_net_properties[] in hw/net/virtio-net.c.
>> > >
>> >
>> > These variables/properties are static variables. What I am looking
>> about is
>> > how can I pass a cli option from qemu into virtio-net driver.
>>
>> When you say "virtio-net driver" I think you mean the virtio-net
>> device emulation code in QEMU?
>>
> Yes, which the virtio-net driver uses to do the network I/O.
>
>>
>> These *are* the properties that can be set from the QEMU command-line.
>> For example:
>>
>>   -device virtio-net-pci,csum=off
>>
> This is the clue, I was looking for. I will see how to proceed from here
> on.
>
But when I have a cli option like below, how can pass above options?
-net nic,macaddr=52:54:00:37:4d:10,model=virtio

-Pradeep


>> The command-line -device option creates device objects using
>> qdev_device_add() and then loops over the command-line parameters
>> calling set_property() on them.
>>
>> Hope this helps you understand the code.
>>
> Thanks, it will really help me to proceed with my work.
>
> Regards,
> Pradeep
>
>>
>> Stefan
>>
>
>