From: Coiby Xu <coiby.xu@gmail.com>
To: qemu-devel@nongnu.org
Subject: Failure of troublesome vhost-user/flags-mismatch test can't be reproduced
Date: Mon, 28 Oct 2019 10:57:09 +0800 [thread overview]
Message-ID: <CAJAkqrUo+8qJGAMprEY2ZxqL-3meHo-56PYc_M1oxXNy5SVvow@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Hi,
Can anyone reproduce the failure of one troublesome test
vhost-user/flags-mismatch (https://wiki.qemu.org/Testing/CI/TroublesomeTests)
which has been disabled since Aug 15 2017 (
https://patchwork.kernel.org/patch/9939431/)? Last month I downloaded QEMU
source code (commit ID: 3483534ec3) and this version also failed this test.
After debugging this issue, I thought I have fixed this issue by saving
acknowledged features after vhost backend disconnect with the client
(qemu). But later I reviewed the commit history of net/vhost-user.c and
found out this test failed on my machines because of a newly introduced
bug from a recent commit (https://patchwork.kernel.org/patch/11054781/) on
July 29 2019 and this new bug has already been fixed by a more recent
commit (
https://lists.sr.ht/~philmd/qemu/%3C20190924162044.11414-1-amorenoz%40redhat.com%3E).
After more investigation, it surprised me both 3.1.0 and 2.9.1could pass
vhost-user/flags-mismatch test. According to the comments on the commit
https://patchwork.kernel.org/patch/9939431/ which disabled the
vhost-user/flags-mismatch and other two tests, it seems the tests are only
broken on travis. Maybe we should re-investigate this issue to re-enable
the test so similar bugs like
https://bugzilla.redhat.com/show_bug.cgi?id=1738768 could be prevented in
the first place.
Btw we can excluisvely check this test on latest QEMU by given TESTPATH and
setting QTEST_VHOST_USER_FIXME environment variable,
QTEST_VHOST_USER_FIXME=1
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qos-test -p
/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-net-pci/virtio-net/virtio-net-tests/vhost-user/flags-mismatch
--
*Best regards,*
*Coiby*
[-- Attachment #2: Type: text/html, Size: 2533 bytes --]
next reply other threads:[~2019-10-28 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 2:57 Coiby Xu [this message]
2019-11-05 16:07 ` Failure of troublesome vhost-user/flags-mismatch test can't be reproduced Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJAkqrUo+8qJGAMprEY2ZxqL-3meHo-56PYc_M1oxXNy5SVvow@mail.gmail.com \
--to=coiby.xu@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).