Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

[Jia Liu <proljc@gmail.com>]

Hi Andreas,

I'll read your patch and try to catch your step.
Thank you very much for reviewing and comments, you make me open my
eyes on QEMU.

On Fri, Jun 8, 2012 at 9:31 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 08.06.2012 15:28, schrieb Andreas Färber:
>> Am 08.06.2012 14:56, schrieb Max Filippov:
>>> On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu <proljc@gmail.com> wrote:
>>>
>>>>        {
>>>>            TCGv_i64 t0 = tcg_temp_new();
>>>>            TCGv_i64 t1 = tcg_temp_new();
>>>>            TCGv_i64 t2 = tcg_temp_new();
>>>>            tcg_gen_mul_tl(t0, cpu_R[ra], cpu_R[rb]);
>>>
>>> t0 should be _tl according to that.
>>
>> You may find these patches helpful for detecting such mismatches:
>> http://patchwork.ozlabs.org/patch/130511/
>
> http://patchwork.ozlabs.org/patch/130566/
>
>> http://patchwork.ozlabs.org/patch/130514/
>> http://patchwork.ozlabs.org/patch/130512/
>>
>> Unfortunately there was no agreement at the time on how to proceed with
>> that feature...
>>
>> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


Regards,
Jia.