From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1ShHQp-0000Nt-08
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 05:42:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1ShHQi-0002FH-Qh
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 05:42:34 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:35041)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1ShHQi-0002Ez-G0
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 05:42:28 -0400
Received: by lbok6 with SMTP id k6so467945lbo.4
	for <qemu-devel@nongnu.org>; Wed, 20 Jun 2012 02:42:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4FE16DB5.3000303@gmail.com>
References: <1339981384-9117-1-git-send-email-proljc@gmail.com>
	<1339981384-9117-12-git-send-email-proljc@gmail.com>
	<4FE16DB5.3000303@gmail.com>
Date: Wed, 20 Jun 2012 17:42:25 +0800
Message-ID: <CAJBMM-twwHqWrDCHDUCxcWBogcc87EZVCKiOibBD+9icv5jpUw@mail.gmail.com>
From: Jia Liu <proljc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 11/16] target-or32: Add a IIS dummy board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

Hi Max,

On Wed, Jun 20, 2012 at 2:29 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On 06/18/2012 05:02 AM, Jia Liu wrote:
>> Add a dummy board for IIS.
>>
>> Signed-off-by: Jia Liu<proljc@gmail.com>
>
> [...]
>
>
>> + =A0 =A0if (nd_table[0].vlan) {
>> + =A0 =A0 =A0 =A0isa_ne2000_init(isa_bus, 0x92000000, 4,&nd_table[0]);
>> + =A0 =A0}
>
> I have noticed that the kernel you provided expects OpenCores ethernet
> device.
> We have a model for it (: You can look at lx60_net_init() in the
> hw/xtensa_lx60.c
> to see how it may be connected.
>

Thank you very much for remind me!

Is this code OK?

static void or1200_net_init(MemoryRegion *address_space,
                            target_phys_addr_t base,
                            target_phys_addr_t buffers,
                            qemu_irq irq, NICInfo *nd)
{
    DeviceState *dev;
    SysBusDevice *s;
    MemoryRegion *ram;

    dev =3D qdev_create(NULL, "open_eth");
    qdev_set_nic_properties(dev, nd);
    qdev_init_nofail(dev);

    s =3D sysbus_from_qdev(dev);
    sysbus_connect_irq(s, 0, irq);
    memory_region_add_subregion(get_system_memory(), base,
                                sysbus_mmio_get_region(s, 0));

    ram =3D g_malloc(sizeof(*ram));
    memory_region_init_ram(ram, "open_eth.ram", 0x100);
    vmstate_register_ram_global(ram);
    memory_region_add_subregion(address_space, buffers, ram);
}

    if (nd_table[0].vlan) {
        or1200_net_init(get_system_memory(), 0x92000000,
                        0x92100000, env->irq[4], nd_table);
    }


> --
> Thanks.
> -- Max

Regards,
Jia.