From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1VDprD-0000KP-9L
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 02:00:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1VDprB-00089I-ME
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 02:00:55 -0400
Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:55498)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <proljc@gmail.com>) id 1VDprB-00089C-Fs
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 02:00:53 -0400
Received: by mail-we0-f180.google.com with SMTP id q58so2313691wes.39
	for <qemu-devel@nongnu.org>; Sun, 25 Aug 2013 23:00:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-af9pM4qAa3x9=6OFdz7mHM-z9yQ6LPh81bYXqYr8Phg@mail.gmail.com>
References: <1377050811-11116-1-git-send-email-proljc@gmail.com>
	<CAFEAcA-af9pM4qAa3x9=6OFdz7mHM-z9yQ6LPh81bYXqYr8Phg@mail.gmail.com>
Date: Mon, 26 Aug 2013 14:00:52 +0800
Message-ID: <CAJBMM-uo2=S1V4FGcR9oe2ESuQbEgyfim5DX2v2w1=tLWVrbrg@mail.gmail.com>
From: Jia Liu <proljc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Xi Wang <xi.wang@gmail.com>

Hi Peter,

On Fri, Aug 23, 2013 at 10:09 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 21 August 2013 03:06, Jia Liu <proljc@gmail.com> wrote:
>> This is my OpenRISC patch queue for 1.7, it have been well tested, please pull.
>>
>>
>> ----------------------------------------------------------------
>> Jia Liu (3):
>>       hw/openrisc: Avoid using uninitialised variable 'entry'
>>       hw/openrisc: Fix masking in openrisc_pic_cpu_handler()
>>       hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler()
>
> Hi -- a couple of minor notes for next time you put together a pull:
>
> (1) your process for putting the git tree together has lost the
> authorship -- these patches weren't written by you, but the
> commits in your git repo (and thus now in master) have you as
> the Author. (If you use 'git am' or Anthony's 'patches apply'
> script it will get this right.)

Thank you for reminding me, I'll use git am next time.

> (2) You should put your own Signed-off-by: line in each patchset,
> as an indication that the patches have come through your tree.
>
> thanks
> -- PMM

Regards,
Jia