From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1RxIjD-0003Oe-MC
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:47:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1RxIj8-0003ar-Ml
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:47:31 -0500
Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:55504)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony.perard@gmail.com>) id 1RxIj8-0003aQ-Gy
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:47:26 -0500
Received: by obbup16 with SMTP id up16so10131510obb.4
	for <qemu-devel@nongnu.org>; Tue, 14 Feb 2012 05:47:25 -0800 (PST)
MIME-Version: 1.0
Sender: anthony.perard@gmail.com
In-Reply-To: <4F3A6C010200007800072E67@nat28.tlf.novell.com>
References: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com>
	<1329135613-26061-11-git-send-email-anthony.perard@citrix.com>
	<4F3A6C010200007800072E67@nat28.tlf.novell.com>
From: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue, 14 Feb 2012 13:46:55 +0000
Message-ID: <CAJJyHj+TKcE6241itt9ECeraEOxSPvFVCZwAZABmc6x0ROADow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH V6 10/11] Introduce Xen PCI
 Passthrough, MSI (3/3)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, Shan Haitao <haitao.shan@intel.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Tue, Feb 14, 2012 at 13:13, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 13.02.12 at 13:20, Anthony PERARD <anthony.perard@citrix.com> wrote:
>> From: Jiang Yunhong <yunhong.jiang@intel.com>
>>
>> A more complete history can be found here:
>> git://xenbits.xensource.com/qemu-xen-unstable.git
>
> This needs to be updated to include the changes in
> http://xenbits.xen.org/gitweb/?p=qemu-xen-unstable.git;a=commitdiff;h=bb36d632e4cabf47882adff07a45c6702c4a5b30
> (and hopefully the broken function that got fixed in
> http://xenbits.xen.org/gitweb/?p=qemu-xen-unstable.git;a=commitdiff;h=8cc8a3651c9c5bc2d0086d12f4b870fc525b9387
> didn't even make it into this patch set).

For the first patch/link, the 'volatile' variable should already be in
the patch (without a separate patch :( ). For the second, yes,
unregister_iomem is done by other functions in QEMU.

> In particular it must be avoided
> to map the MSI-X table with PROT_WRITE, and the respective MMIO
> range should not get assigned to the guest at all.

I will check that.

Regards,

-- 
Anthony PERARD