From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.spyridakis@virtualopensystems.com>)
	id 1ZYwaI-0005d7-D3
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 09:35:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <a.spyridakis@virtualopensystems.com>)
	id 1ZYwaD-00015t-KU
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 09:35:45 -0400
Received: from mail-la0-f51.google.com ([209.85.215.51]:35047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.spyridakis@virtualopensystems.com>)
	id 1ZYwaD-00015g-EP
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 09:35:41 -0400
Received: by lagj9 with SMTP id j9so52634999lag.2
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 06:35:40 -0700 (PDT)
Received: from mail-la0-f51.google.com (mail-la0-f51.google.com.
	[209.85.215.51]) by smtp.googlemail.com with ESMTPSA id
	g3sm11006lah.15.2015.09.07.06.35.39 for <qemu-devel@nongnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Mon, 07 Sep 2015 06:35:39 -0700 (PDT)
Received: by lanb10 with SMTP id b10so51725620lan.3
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 06:35:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20150904140528.GH3096@hawk.localdomain>
References: <1441185926-61587-1-git-send-email-a.spyridakis@virtualopensystems.com>
	<1441185926-61587-3-git-send-email-a.spyridakis@virtualopensystems.com>
	<20150904104835.GC3096@hawk.localdomain>
	<CAJRNFKKQsAxVkCb8fzO=jshiQFdsipSAaAg8Vc-LAF+HY-7QwA@mail.gmail.com>
	<20150904140528.GH3096@hawk.localdomain>
From: Alexander Spyridakis <a.spyridakis@virtualopensystems.com>
Date: Mon, 7 Sep 2015 15:35:19 +0200
Message-ID: <CAJRNFKLecMMBi9ApQsY1DUyKRcejfUW4bu5Nz8JbQZ3pcmoHrg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix
 arch_clean rule
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: mttcg@greensocs.com, Mark Burton <mark.burton@greensocs.com>, KVM General <kvm@vger.kernel.org>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Jani Kokkonen <Jani.Kokkonen@huawei.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>

On 4 September 2015 at 16:05, Andrew Jones <drjones@redhat.com> wrote:
> This doesn't reproduce for me. I did the following, and it worked
> fine.
>
> make distclean
> ./configure --arch=arm --cross-prefix=arm-linux-gnu-
> make
> ./configure --arch=arm64 --cross-prefix=aarch64-linux-gnu-
> make clean && make

Ok I think I found the issue:

config-arm-common.mak:
>arm_clean: libfdt_clean asm_offsets_clean
>    $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \
>          $(TEST_DIR)/.*.d lib/arm/.*.d

config-x86-common.mak:
>arch_clean:
>    $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
>    $(TEST_DIR)/.*.d lib/x86/.*.d

I think the arm case tries to be too clever and on many systems it
fails (tested on debian:jessie,sid and ubuntu:14.04,15.04). Basically
the expression for the arm case fails to resolve, while using the
simpler x86 way works as expected.

So is the following change acceptable in config-arm-common.mak?
> arm_clean: libfdt_clean asm_offsets_clean
>-       $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \
>-             $(TEST_DIR)/.*.d lib/arm/.*.d
>+       $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
>+               $(libeabi) $(eabiobjs) $(TEST_DIR)/.*.d lib/arm/.*.d

Thanks.