qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	Cleber Rosa <crosa@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com,
	 hczenczek@redhat.com, gmaglione@redhat.com,
	virtio-fs@redhat.com,  pbonzini@redhat.com,
	alex.bennee@linaro.org
Subject: Re: [PATCH 0/3] Remove C virtiofsd
Date: Wed, 18 Jan 2023 10:59:30 -0500	[thread overview]
Message-ID: <CAJSP0QU+o-R6ZKN8R1MHoUqFwfsQmpKt6KP5hqhyFrK5HJti6w@mail.gmail.com> (raw)
In-Reply-To: <20230118153833.102731-1-dgilbert@redhat.com>

On Wed, 18 Jan 2023 at 10:40, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a
> in v7.0 in favour of the Rust implementation at
>
>   https://gitlab.com/virtio-fs/virtiofsd
>
> since then, the Rust version has had more development and
> has held up well.  It's time to say goodbye to the C version
> that got us going.
>
> The only thing I've not cleaned up here is
>   tests/avocado/virtiofs_submounts.py
>
> which I guess needs to figure out where the virtiofsd implementation
> is and use it; suggestions welcome.

I see something similar in tests/avocado/avocado_qemu/__init__.py:

        # If qemu-img has been built, use it, otherwise the system wide one
        # will be used.  If none is available, the test will cancel.
        qemu_img = os.path.join(BUILD_DIR, 'qemu-img')
        if not os.path.exists(qemu_img):
            qemu_img = find_command('qemu-img', False)
        if qemu_img is False:
            self.cancel('Could not find "qemu-img", which is required to '
                        'create the bootable image')

Maybe find_command('virtiofsd', False)?

Stefan


  parent reply	other threads:[~2023-01-18 16:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 15:38 [PATCH 0/3] Remove C virtiofsd Dr. David Alan Gilbert (git)
2023-01-18 15:38 ` [PATCH 1/3] virtiofsd: Remove build and docs glue Dr. David Alan Gilbert (git)
2023-01-18 15:38 ` [PATCH 2/3] virtiofsd: Remove source Dr. David Alan Gilbert (git)
2023-01-18 15:38 ` [PATCH 3/3] virtiofsd: Swing deprecated message to removed-features Dr. David Alan Gilbert (git)
2023-01-18 15:59 ` Stefan Hajnoczi [this message]
2023-01-19 10:14   ` [PATCH 0/3] Remove C virtiofsd Hanna Czenczek
2023-01-19 14:56     ` Alex Bennée
2023-01-18 16:00 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJSP0QU+o-R6ZKN8R1MHoUqFwfsQmpKt6KP5hqhyFrK5HJti6w@mail.gmail.com \
    --to=stefanha@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=gmaglione@redhat.com \
    --cc=hczenczek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).