[Qemu-devel] [patch] correct tracing.txt

[Qemu-devel] [patch] correct tracing.txt

[Jun Koi]

this patch corrects the configure's trace option in docs/tracing.txt

Signed-off-by: Jun Koi <junkoi2004@gmail.com>

 diff --git a/docs/tracing.txt b/docs/tracing.txt
index ea29f2c..7b11d15 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -9,7 +9,7 @@ for debugging, profiling, and observing execution.

 1. Build with the 'simple' trace backend:

-    ./configure --trace-backend=simple
+    ./configure --enable-trace-backend=simple
     make

 2. Create a file with the events you want to trace:

Re: [Qemu-devel] [patch] correct tracing.txt

[陳韋任]

  Simple patch should cc to qemu-trivial@nongnu.org :).
 
On Thu, Mar 08, 2012 at 04:24:52PM +0800, Jun Koi wrote:
> this patch corrects the configure's trace option in docs/tracing.txt
> 
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
> 
>  diff --git a/docs/tracing.txt b/docs/tracing.txt
> index ea29f2c..7b11d15 100644
> --- a/docs/tracing.txt
> +++ b/docs/tracing.txt
> @@ -9,7 +9,7 @@ for debugging, profiling, and observing execution.
> 
>  1. Build with the 'simple' trace backend:
> 
> -    ./configure --trace-backend=simple
> +    ./configure --enable-trace-backend=simple
>      make
> 
>  2. Create a file with the events you want to trace:

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [patch] correct tracing.txt

[Stefan Hajnoczi]

On Thu, Mar 08, 2012 at 04:24:52PM +0800, Jun Koi wrote:
> this patch corrects the configure's trace option in docs/tracing.txt
> 
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
> 
>  diff --git a/docs/tracing.txt b/docs/tracing.txt
> index ea29f2c..7b11d15 100644
> --- a/docs/tracing.txt
> +++ b/docs/tracing.txt
> @@ -9,7 +9,7 @@ for debugging, profiling, and observing execution.
> 
>  1. Build with the 'simple' trace backend:
> 
> -    ./configure --trace-backend=simple
> +    ./configure --enable-trace-backend=simple
>      make
> 
>  2. Create a file with the events you want to trace:
> 

This may conflict with other patches on the list - I haven't sent a
tracing pull request for far too long and there are a bunch of
outstanding patches.  But since it's here in a convenient patch email,
let's take this!

Thanks, applied to the tracing patches tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

Re: [Qemu-devel] [patch] correct tracing.txt

[Stefan Hajnoczi]

On Thu, Mar 8, 2012 at 8:30 AM, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
>  Simple patch should cc to qemu-trivial@nongnu.org :).

Not in all cases.  qemu-trivial is a catch-all for simple patches so
we don't forget them.  It was a solution to the problem that patches
were often forgotten if they touch a QEMU subsystem that isn't
actively maintained.

In the case where you know there is an active maintainer - like pci,
block, ppc, tracing, etc - then it's fine to send it via the
maintainer instead of qemu-trivial.  qemu-trivial is a safety net so
that we don't drop simple patches just because no one feels
responsible for them.

Jun Koi: It's worth CCing the maintainer (see ./MAINTAINERS) so they
don't miss your patch.

Stefan

Re: [Qemu-devel] [patch] correct tracing.txt

[Peter Maydell]

On 9 March 2012 10:20, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> Not in all cases.  qemu-trivial is a catch-all for simple patches so
> we don't forget them.  It was a solution to the problem that patches
> were often forgotten if they touch a QEMU subsystem that isn't
> actively maintained.

I think you could argue that our documentation counts as a "subsystem
that isn't actively maintained" :-)

-- PMM

Re: [Qemu-devel] [patch] correct tracing.txt

[Stefan Hajnoczi]

On Fri, Mar 9, 2012 at 11:48 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 9 March 2012 10:20, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> Not in all cases.  qemu-trivial is a catch-all for simple patches so
>> we don't forget them.  It was a solution to the problem that patches
>> were often forgotten if they touch a QEMU subsystem that isn't
>> actively maintained.
>
> I think you could argue that our documentation counts as a "subsystem
> that isn't actively maintained" :-)

If it's tracing then I'll look at it - although I'm admittedly very
behind on my patch queue.

Stefan