Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files

[Stefan Hajnoczi <stefanha@gmail.com>]

On Mon, Aug 12, 2013 at 1:28 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote:
>> @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs,
>>      return ret;
>>  }
>>
>> +static int vmdk_open_vmfs_sparse(BlockDriverState *bs,
>> +                                 BlockDriverState *file,
>> +                                 int flags)
>> +{
>> +    int ret;
>> +    uint32_t magic;
>> +    VMDK3Header header;
>> +    VmdkExtent *extent;
>> +
>> +    ret = bdrv_pread(file, sizeof(magic), &header, sizeof(header));
>> +    if (ret < 0) {
>> +        return ret;
>> +    }
>
> magic is unused.  Did you forget to check it?

Andreas Färber pointed out that we're only using the sizeof(magic),
not the actual variable.

Feel free to ignore my comment, at least the code documents that the
uint32_t offset belongs to the magic number before the header.

Stefan