From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qYe-0006FA-1a
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:45:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qYZ-0002ZY-D7
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:45:07 -0400
Received: from mail-qa0-x22f.google.com ([2607:f8b0:400d:c00::22f]:53268)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V8qYZ-0002ZA-5f
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 07:45:03 -0400
Received: by mail-qa0-f47.google.com with SMTP id o19so934858qap.20
	for <qemu-devel@nongnu.org>; Mon, 12 Aug 2013 04:45:02 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20130812112814.GA20725@stefanha-thinkpad.redhat.com>
References: <1376237638-6968-1-git-send-email-pbonzini@redhat.com>
	<1376237638-6968-2-git-send-email-pbonzini@redhat.com>
	<20130812112814.GA20725@stefanha-thinkpad.redhat.com>
Date: Mon, 12 Aug 2013 13:45:02 +0200
Message-ID: <CAJSP0QU8ACAkSwREmjqkmBntcv7VUhvvZZLQe5RWbFPiJ13Xxg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Mon, Aug 12, 2013 at 1:28 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote=
:
> On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote:
>> @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs,
>>      return ret;
>>  }
>>
>> +static int vmdk_open_vmfs_sparse(BlockDriverState *bs,
>> +                                 BlockDriverState *file,
>> +                                 int flags)
>> +{
>> +    int ret;
>> +    uint32_t magic;
>> +    VMDK3Header header;
>> +    VmdkExtent *extent;
>> +
>> +    ret =3D bdrv_pread(file, sizeof(magic), &header, sizeof(header));
>> +    if (ret < 0) {
>> +        return ret;
>> +    }
>
> magic is unused.  Did you forget to check it?

Andreas F=E4rber pointed out that we're only using the sizeof(magic),
not the actual variable.

Feel free to ignore my comment, at least the code documents that the
uint32_t offset belongs to the magic number before the header.

Stefan