From: Stefan Hajnoczi <stefanha@gmail.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fix qemu build with nas installed
Date: Wed, 21 Sep 2011 11:16:37 +0100 [thread overview]
Message-ID: <CAJSP0QUA4c7B-ZDEKUV_9Bth5n0YXXUrN_7APJjPy4k8oL8a5Q@mail.gmail.com> (raw)
In-Reply-To: <4E79AF93.4030207@amd.com>
On Wed, Sep 21, 2011 at 10:34 AM, Christoph Egger
<Christoph.Egger@amd.com> wrote:
>
> When NAS (http://nas.sf.net) is installed then there
> is an existing audio/audio.h. Then when compiling
> qemu, #include "audio/audio.h" takes the one from NAS
> and causes the build to fail.
>
> So rename audio/audio.h to audio/qaudio.h and adjust
> all users.
>
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> diff --git a/arch_init.c b/arch_init.c
> index 9a5a0e3..516c4c0 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -32,7 +32,7 @@
> #include "monitor.h"
> #include "sysemu.h"
> #include "arch_init.h"
> -#include "audio/audio.h"
> +#include "audio/qaudio.h"
It's not looking for system headers so why is
/usr/include/audio/audio.h getting picked up instead of
./audio/audio.h?
If it was #include <audio/audio.h> I could understand but I suspect we
have a mess of include paths that the compiler is searching and it
would be nice to fix that instead.
Stefan
next prev parent reply other threads:[~2011-09-21 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 9:34 [Qemu-devel] [PATCH] fix qemu build with nas installed Christoph Egger
2011-09-21 10:16 ` Stefan Hajnoczi [this message]
2011-09-27 8:20 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QUA4c7B-ZDEKUV_9Bth5n0YXXUrN_7APJjPy4k8oL8a5Q@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=Christoph.Egger@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).