From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
"\"Chen Wei-Ren (陳韋任)\"" <chenwj@iis.sinica.edu.tw>
Subject: Re: [Qemu-devel] [PATCH v3 5/6] Makefile.objs: Remove libqemu_common.a from the comment
Date: Fri, 9 Dec 2011 14:29:51 +0000 [thread overview]
Message-ID: <CAJSP0QUD4T7TP=hdgf01t-u6xJTexikhy3t-bc93k0MWeP=zhg@mail.gmail.com> (raw)
In-Reply-To: <CAJSP0QWf03A-qOGyGA_P9vaL7mS5f-K5sBgWvd0ssudGqSkfsA@mail.gmail.com>
On Fri, Dec 9, 2011 at 11:28 AM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Fri, Dec 9, 2011 at 11:09 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Am 15.11.2011 13:47, schrieb Chen Wei-Ren (陳韋任):
>>> From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
>>>
>>> Remove libqemu_common.a from the comment.
>>>
>>> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
>>> ---
>>> Makefile.objs | 7 +++----
>>> 1 files changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Makefile.objs b/Makefile.objs
>>> index d7a6539..64c5c24 100644
>>> --- a/Makefile.objs
>>> +++ b/Makefile.objs
>>> @@ -68,10 +68,9 @@ endif
>>> fsdev-obj-$(CONFIG_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y))
>>>
>>> ######################################################################
>>> -# libqemu_common.a: Target independent part of system emulation. The
>>> -# long term path is to suppress *all* target specific code in case of
>>> -# system emulation, i.e. a single QEMU executable should support all
>>> -# CPUs and machines.
>>> +# Target independent part of system emulation. The long term path is
>>> +# to suppress *all* target specific code in case of # system emulation,
>>
>> Stefan, could you still fix this up, please? (stray comment sign)
>
> Fixed, though it's the second time today I modified someone's commit
> before merging it and I'm feeling a little dirty:
> http://repo.or.cz/w/qemu/stefanha.git/commitdiff/b745d5e0c0eef709eda618020d82a283a7576820
Thanks to Peter Maydell for pointing out that I posted the old commit
URL instead of the fixed one.
Here's the fixed version in the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/commitdiff/050d99402845d3c5915e3abd8aea7cc772b85b8e
Stefan
next prev parent reply other threads:[~2011-12-09 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 12:47 [Qemu-devel] [PATCH v3 0/6] Remove libqemu related stuff from QEMU source tree Chen Wei-Ren (陳韋任)
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 1/6] tests/Makefile: Remove qruncom target Chen Wei-Ren (陳韋任)
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 2/6] tests/qruncom.c: Remove libqemu.a example Chen Wei-Ren (陳韋任)
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 3/6] qemu-tech.texi: Remove libqemu related stuff from the document Chen Wei-Ren (陳韋任)
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 4/6] Makefile.target: Remove out of date comment Chen Wei-Ren (陳韋任)
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 5/6] Makefile.objs: Remove libqemu_common.a from the comment Chen Wei-Ren (陳韋任)
2011-12-09 11:09 ` Andreas Färber
2011-12-09 11:28 ` Stefan Hajnoczi
2011-12-09 14:29 ` Stefan Hajnoczi [this message]
2011-11-15 12:47 ` [Qemu-devel] [PATCH v3 6/6] LICENSE: There is no libqemu.a anymore Chen Wei-Ren (陳韋任)
2011-12-06 16:15 ` [Qemu-devel] [PATCH v3 0/6] Remove libqemu related stuff from QEMU source tree Peter Maydell
2011-12-06 19:50 ` Stuart Brady
2011-12-09 10:57 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QUD4T7TP=hdgf01t-u6xJTexikhy3t-bc93k0MWeP=zhg@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=chenwj@iis.sinica.edu.tw \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).